Open
Conversation
Updated meeting details for the Node.js Security Working Group, including new calendar filter and ICAL URL.
There was a problem hiding this comment.
Pull request overview
Updates the Node.js Security WG meeting template to use the Linux Foundation LFX calendar feed and Zoom LFX joining link (per nodejs/security-wg#1558), replacing the previous Google Calendar iCal source and placeholder joining instructions.
Changes:
- Switched
ICAL_URLfrom Google Calendar to an LFX webcal endpoint. - Updated
CALENDAR_FILTERto match the new LFX event naming. - Replaced the participant join link with the Zoom LFX meeting URL.
Comments suppressed due to low confidence (1)
templates/meeting_base_security-wg:11
JOINING_INSTRUCTIONSstarts a quoted multi-line value but is never closed with a terminating".dotenv.parse()requires the closing quote for multi-line values; as-is this will break meeting config parsing forsecurity-wg(and may cause subsequent properties to be misparsed). Add the closing quote line (consistent with othermeeting_base_*templates) so the template remains valid dotenv syntax.
JOINING_INSTRUCTIONS="
* link for participants: <https://zoom-lfx.platform.linuxfoundation.org/meeting/92626800362?password=78ffb026-dfb9-4549-b8cd-c3b82bd907f7>
* For those who just want to watch We stream our conference call straight to YouTube so anyone can listen to it live, it should start playing at <https://www.youtube.com/c/nodejs+foundation/live> when we turn it on. There's usually a short cat-herding time at the start of the meeting and then occasionally we have some quick private business to attend to before we can start recording & streaming. So be patient and it should show up.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/security-wg#1558