Skip to content

Fix: Pre-create node_modules with correct ownership for non-root users #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mulder999 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Fix: Pre-create node_modules with correct ownership for non-root users #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile-alpine.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ ENV NODE_VERSION=0.0.0

RUN addgroup -g 1000 node \
&& adduser -u 1000 -G node -s /bin/sh -D node \
&& mkdir -p /home/node/node_modules \
&& chown -R node:node /home/node/node_modules \
&& apk add --no-cache \
libstdc++ \
&& apk add --no-cache --virtual .build-deps \
Expand Down
4 changes: 3 additions & 1 deletion Dockerfile-debian.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM buildpack-deps:name

RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node \
&& mkdir -p /home/node/node_modules \
&& chown -R node:node /home/node/node_modules

ENV NODE_VERSION=0.0.0

Expand Down
4 changes: 3 additions & 1 deletion Dockerfile-slim.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM debian:name-slim

RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node \
&& mkdir -p /home/node/node_modules \
&& chown -R node:node /home/node/node_modules

ENV NODE_VERSION=0.0.0

Expand Down