Skip to content

test: skip test-cluster-dgram-reuse on AIX 7.3#62238

Draft
sxa wants to merge 2 commits intonodejs:mainfrom
sxa:aix733-dgram-fix
Draft

test: skip test-cluster-dgram-reuse on AIX 7.3#62238
sxa wants to merge 2 commits intonodejs:mainfrom
sxa:aix733-dgram-fix

Conversation

@sxa
Copy link
Member

@sxa sxa commented Mar 13, 2026

Identified during AIX 7.3 testing being done under #61660

TL;DR This is a workaround for a hang which is showing up when node is built on or AIX 7.3 machines. If the binary is built on 7.2 and then run on 7.3 (which would be true for anyone using our release builds) then it seems to work ok. It is a consistently reproducible failure.

While this version check technically stops an AIX 7.2 binary being tested on 7.3 it is an appropriate change to allow AIX 7.3 to be included in the CI without impacting the coverage we have on 7.2.

Alternate solutions:

  • Expose this through common and use it there (Suggestions on variable names etc. welcome if we go for this, but I don't think there's too much precedent)
  • Identify and fix the underlying problem (Analysis there will continue todo this anyway, but I'd rather not hold up adding 7.3 - which is now nearly 5 years old - into the mix right now if possible since we're very close to being able to do that now)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 13, 2026
Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa sxa force-pushed the aix733-dgram-fix branch from 94e18a5 to 83fa65a Compare March 13, 2026 13:09
@sxa sxa changed the title test: skip tet-cluster-dgram-reuse on AIX 7.3 test: skip test-cluster-dgram-reuse on AIX 7.3 Mar 13, 2026
@sxa sxa added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2026
@sxa
Copy link
Member Author

sxa commented Mar 13, 2026

(Force push to fix typo in commit message)

@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 13, 2026
@github-actions
Copy link
Contributor

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/23052607472

@nodejs-github-bot
Copy link
Collaborator

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants