test: skip test-cluster-dgram-reuse on AIX 7.3#62238
Draft
sxa wants to merge 2 commits intonodejs:mainfrom
Draft
test: skip test-cluster-dgram-reuse on AIX 7.3#62238sxa wants to merge 2 commits intonodejs:mainfrom
sxa wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Member
Author
|
(Force push to fix typo in commit message) |
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/23052607472 |
Collaborator
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified during AIX 7.3 testing being done under #61660
TL;DR This is a workaround for a hang which is showing up when node is built on or AIX 7.3 machines. If the binary is built on 7.2 and then run on 7.3 (which would be true for anyone using our release builds) then it seems to work ok. It is a consistently reproducible failure.
While this version check technically stops an AIX 7.2 binary being tested on 7.3 it is an appropriate change to allow AIX 7.3 to be included in the CI without impacting the coverage we have on 7.2.
Alternate solutions:
commonand use it there (Suggestions on variable names etc. welcome if we go for this, but I don't think there's too much precedent)