Skip to content

quic: remove unused binding variable in session.cc #63177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasnell wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −10
Open

quic: remove unused binding variable in session.cc #63177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
398882c
quic: remove unused binding variable in session.cc
jasnell May 7, 2026
6e2ea36
quic: remove unused env_ variable in session_manager.h/cc
jasnell May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/quic/bindingdata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ BindingData::BindingData(Realm* realm, Local<Object> object)

SessionManager& BindingData::session_manager() {
if (!session_manager_) {
session_manager_ = std::make_unique<SessionManager>(env());
session_manager_ = std::make_unique<SessionManager>();
}
return *session_manager_;
}
Expand Down
1 change: 0 additions & 1 deletion src/quic/session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,6 @@ Session::Session(Endpoint* endpoint,

MakeWeak();
Debug(this, "Session created.");
auto& binding = BindingData::Get(env());

JS_DEFINE_READONLY_PROPERTY(
env(), object, env()->stats_string(), impl_->stats_.GetArrayBuffer());
Expand Down
4 changes: 0 additions & 4 deletions src/quic/session_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@

namespace node::quic {

SessionManager::SessionManager(Environment* env) : env_(env) {}

SessionManager::~SessionManager() = default;

BaseObjectPtr<Session> SessionManager::FindSession(const CID& cid) {
// Direct SCID match.
auto it = sessions_.find(cid);
Expand Down
6 changes: 2 additions & 4 deletions src/quic/session_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ class Session;
// It is not exposed to JavaScript.
class SessionManager final {
public:
explicit SessionManager(Environment* env);
~SessionManager();
explicit SessionManager() = default;
~SessionManager() = default;

// Session routing. The sessions_ map holds BaseObjectPtr<Session> (owning
// references). SessionManager is the single authority for session ownership.
Expand Down Expand Up @@ -78,8 +78,6 @@ class SessionManager final {
bool is_empty() const;

private:
Environment* env_;

// The sessions_ map holds strong owning references keyed by locally-
// generated SCIDs. This is the single source of truth for session
// ownership.
Expand Down
Loading