fix(h2): TypeError: Cannot read properties of null (reading 'push') i…

[hxinhan]

This relates to...

#4880

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.01%. Comparing base (07276c9) to head (eba9d9f).

Files with missing lines	Patch %	Lines
lib/dispatcher/client-h2.js	50.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4881   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         112      112           
  Lines       35287    35287           
=======================================
  Hits        32823    32823           
  Misses       2464     2464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Can you solve the TOCTOU without adding the ? guard. That sit in a hot path, and it's likely that it will add some overhead.

[hxinhan]

Can you solve the TOCTOU without adding the ? guard. That sit in a hot path, and it's likely that it will add some overhead.

I'm not sure how to avoid a non-null check for res. I've removed that now.

Only with the change of moving stream.on('data', ...), the issue is still not reproducible in the regression test issue-4880.js

[metcoder95]

lgtm