Repository navigation
Run the recipe harness through the standard Test target - #138
Merged
Merged
Conversation
Replace the recipe repository's compiled-test discovery with its existing behavior and smoke harness. Propagate child failures before packaging and publication, and remove the duplicate workflow step. Co-authored-by: OpenAI Codex <noreply@openai.com>
CharliePoole
approved these changes
Nov 4, 2026
CharliePoole
left a comment
Member
There was a problem hiding this comment.
Thanks, I like this much better than the separate step in our workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137.
The recipe’s normal Test target currently succeeds after finding zero compiled test assemblies, while CI runs the source harness in a separate workflow step. This change makes the Test target run the existing behavior and smoke harness, so the standard BuildTestAndPackage and ContinuousIntegration sequences stop before packaging or publishing when either fails.
The override replaces only the Test action, preserving its Build dependency and standard --notests criterion. The harness runs in a separate Cake process because its fixtures deliberately replace static recipe settings; those temporary settings must not affect the parent’s real package definition. A nonzero child exit throws a CakeException in the parent.
The separate CI harness step is removed to avoid running it twice. Existing report uploads and publication settings remain unchanged. The reusable recipe scripts are unchanged; the override is specific to this repository’s build.cake.
Validation on Windows with SDK 10.0.403 and pinned Cake.Tool 6.3.0:
The injected failures are validation controls only and are not included in this change. Native non-Windows integration and hosted CI have not been run for this candidate.
Prepared by Neil Colvin with assistance from OpenAI Codex.