Repository navigation
Conversation
The service detail page renders two error banners -- "failed to load template" and "install failed" -- as plain <div class="error">. They were rendered visually but announced to nothing: a screen reader user who triggered an install failure got no notification that anything had gone wrong, because the banner is injected into an already-loaded page and a bare div is not a live region. Adding role="alert" makes both an assertive live region, so the message is announced when it appears. This is the existing house convention -- see lib/components/Toast.svelte:7, which already does exactly this. Zero visual change: role is semantics only and the .error class is untouched. Verified present as a live alert node in the CDP accessibility tree. Gates: `npm run build` clean (adapter-static). `npm run check` reports 2 errors / 52 warnings, all pre-existing in lib/index.ts:4 and applications/[id]/+page.svelte:1137; zero diagnostics in the touched file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
role="alert"to the two error banners on the service detail page(
frontend/src/routes/services/[slug]/+page.svelte): the failed to loadtemplate banner and the install failed banner.
Why
Both banners were rendered visually but announced to nothing. They are injected
into an already-loaded page, and a bare
<div>is not a live region — so ascreen reader user who triggered an install failure received no notification
that anything had gone wrong. The failure was silent to exactly the users least
able to infer it from context.
role="alert"makes each an assertive live region, announced on insertion.This is the existing house convention rather than a new pattern:
lib/components/Toast.svelte:7already does the same thing.Visual impact
None.
roleis semantics only; the.errorclass and all styling areuntouched. Verified present as a live alert node in the CDP accessibility tree.
Gates
npm run build— clean, adapter-static.npm run check— 2 errors / 52 warnings, all pre-existing inlib/index.ts:4andapplications/[id]/+page.svelte:1137. Zero diagnosticsin the touched file. Deliberately not fixed here.
Provenance
The change itself was authored under card t_6d808cb4 and then stranded as an
uncommitted diff in the shared checkout, where it survived one near-miss during
an unrelated rebase. This PR commits it on its own branch cut from
origin/mainso it stops being a change waiting to be lost.