fix(Header): move container slot classes into theme for doc accuracy#6300
fix(Header): move container slot classes into theme for doc accuracy#6300faizkhairi wants to merge 2 commits intonuxt:v4from
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
|
Closing this as the documentation reflects what each component defines. We're not going to stop using reusable components. |
Description
Fixes #6298
The
UHeadercontainer slot was rendered via<UContainer>, which silently adds its own base classes (w-full max-w-(--ui-container) mx-auto px-4 sm:px-6 lg:px-8) to the element. Theheader.tstheme only definedflex items-center justify-between gap-3 h-full, so the docs showed an incomplete class list.Root Cause
Header.vueused<UContainer>for the container slot, butUContainerinjects its own base classes outside the theming system. This caused a mismatch between what the docs display (fromheader.ts) and what is actually rendered in the DOM.Fix
<UContainer>with a plain<div>inHeader.vueUContainerbase classes directly to thecontainerslot inheader.tsUContainerimportThe rendered output is identical -- the snapshots confirm this. The only change is that all container classes are now explicitly defined in the theme, making the docs accurate and the slot fully customizable via the
uiprop.Tests
All existing tests and snapshots pass without modification.