Feature/multi language support#471
Open
kellyy0 wants to merge 14 commits into
Open
Conversation
…ctual string values
Collaborator
|
/gpt-review |
Collaborator
|
Sorry it's taken so long for this to get a real review — and thanks for tackling i18n, it's overdue. Unfortunately the implementation has a few correctness bugs that I think need addressing before this can land. The general principle is: once you localize, never compare or store UI strings as control flow — only compare resource IDs.
Could you also confirm the PR has been tested end-to-end on a real device with at least one non-English locale (start the app, open every feature category, switch language at runtime, navigate everywhere) before re-requesting review? The current state would crash / show garbled text in several places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.