Skip to content

updated dependency and deleted package-lock.json#481

Open
isha382 wants to merge 1 commit into
ob-f:masterfrom
3dwesupport:update/dependency-bot-dependency
Open

updated dependency and deleted package-lock.json#481
isha382 wants to merge 1 commit into
ob-f:masterfrom
3dwesupport:update/dependency-bot-dependency

Conversation

@isha382
Copy link
Copy Markdown
Contributor

@isha382 isha382 commented Feb 3, 2025

updated dependency and deleted package-lock.json

@thias15
Copy link
Copy Markdown
Collaborator

thias15 commented May 8, 2026

Sorry for taking so long to look at this — and thanks for the contribution!

A larger PR (#507) is now open and approved that updates the same controller/web-server/package.json and server/package.json files much more comprehensively (and also touches the rest of the project's dependency stack). Once #507 lands, the package.json changes here will be subsumed.

Two questions before deciding:

  1. Are you okay if we close this in favor of Dependency updates to latest versions. #507, or is there a specific reason you'd prefer this PR's narrower change to land first?
  2. The ws ^7.5.0 → ^8.18.0 jump on the server side is a major version bump — did you verify the websocket connection between the server and the OpenBot controller still works after the upgrade? (ws v8 changed some defaults around perMessageDeflate and event handling.)

If you'd like to keep this open as a fallback in case #507 stalls, that's fine — but in that case we'd want answers to #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants