Skip to content

Training policy updates#509

Open
harishthakur52 wants to merge 6 commits into
ob-f:masterfrom
3dwesupport:training-policy-updates
Open

Training policy updates#509
harishthakur52 wants to merge 6 commits into
ob-f:masterfrom
3dwesupport:training-policy-updates

Conversation

@harishthakur52
Copy link
Copy Markdown
Contributor

No description provided.

@sparsh3dwe sparsh3dwe requested a review from Copilot April 7, 2026 05:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Python dependency versions used for the policy training workflow.

Changes:

  • Bumped Jupyter notebook, matplotlib, pillow, numpyencoder, and black versions in policy/requirements.txt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread policy/requirements.txt
Comment on lines +1 to +5
notebook~=7.5.5
matplotlib~=3.9.4
pillow~=10.4.0
numpyencoder~=0.3.2
black[jupyter]~=25.11.0
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependency bumps make policy/requirements.txt diverge significantly from the pinned versions in the provided conda env files (e.g., environment_linux.yml pins notebook==6.4.12, matplotlib==3.6.3, numpyencoder==0.3.0, black==23.1.0). Since the README recommends either using the env files or doing a manual setup that ends with pip install -r requirements.txt, this mismatch can lead to inconsistent or conflicting environments depending on which path a user follows. Consider either updating the conda environment files to match these versions, or documenting that requirements.txt is intended for a different setup path (and should not be mixed with the env YAMLs).

Suggested change
notebook~=7.5.5
matplotlib~=3.9.4
pillow~=10.4.0
numpyencoder~=0.3.2
black[jupyter]~=25.11.0
notebook==6.4.12
matplotlib==3.6.3
pillow~=10.4.0
numpyencoder==0.3.0
black==23.1.0

Copilot uses AI. Check for mistakes.
@thias15
Copy link
Copy Markdown
Collaborator

thias15 commented Apr 16, 2026

Fully tested and ready to be merged?

@harishthakur52
Copy link
Copy Markdown
Contributor Author

Yes, tested.

@thias15
Copy link
Copy Markdown
Collaborator

thias15 commented May 8, 2026

Overall: The Copilot review above is stale — it didn't notice the env yamls were also updated in this PR, so its rollback suggestion can be ignored. A few things worth flagging:

  1. Notebook 6 → 7 is a major rewrite (Jupyter Notebook 7 is built on JupyterLab; UI, extensions, and some classic-UI features differ significantly). Worth confirming the existing .ipynb files in policy/ still open and execute end-to-end on Notebook 7, especially any cells relying on classic nbextensions or custom widgets.
  2. numpy<2 ceiling — intentional? Adding this constraint blocks NumPy 2.x. If the reason is that TensorFlow or another dep doesn't yet support NumPy 2, please add a comment in the env file (or note in the PR) so future maintainers know when it's safe to lift. If it's just defensive, drop it.
  3. black 23 → 25 is a major bump. Notebook formatting rules and quote handling have changed across versions. The next time anyone runs black on the policy code/notebooks, expect a large formatting-churn diff. Worth running black . once now and committing the result so it doesn't pollute a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants