Skip to content

Local NodeWebserverBrowserController updated Node 18-25 #490#511

Open
iwl wants to merge 4 commits into
ob-f:masterfrom
iwl:brwsctrl
Open

Local NodeWebserverBrowserController updated Node 18-25 #490#511
iwl wants to merge 4 commits into
ob-f:masterfrom
iwl:brwsctrl

Conversation

@iwl
Copy link
Copy Markdown

@iwl iwl commented Apr 23, 2026

Local NodeWebserverBrowserController updated Node 18-25
OpenBot/controller/node-js npm install npm start
First connect Browser http://Server:8081 , then OpenBot (close app,retry)
Works Linux, Win10, Firewall Open tcp 19400 (8081 extern Browser)
Videostream works, no car yet for control test
Fixes #490

@iwl iwl changed the title Lokal BrowserCtrl Pi 4 Bookworm 32 Node 20 Lokal BrowserCtrl Pi 4 Bookworm 32 Node 20 #490 Apr 23, 2026
@iwl iwl changed the title Lokal BrowserCtrl Pi 4 Bookworm 32 Node 20 #490 Local NodeWebserverBrowserController updated Node 18-25 #490 Apr 24, 2026
@thias15
Copy link
Copy Markdown
Collaborator

thias15 commented May 8, 2026

Overall: Good modernization — Snowpack is unmaintained and this should restore Node 18-25 compatibility. The JSON.parse(data).status change looks like a real bug fix (the previous (data).status was a no-op cast).

  1. End-to-end test on a real bot is needed before merging. The PR description notes "Videostream works, no car yet for control test." The JSON.parse fix sits directly on the message path from the OpenBot app, so control behavior could regress (or finally work) — we shouldn't merge without confirming a live device can drive.
  2. ESLint 9 uses flat config by default. Does npm run lint still pass? v9 dropped support for .eslintrc unless ESLINT_USE_FLAT_CONFIG=false is set, and eslint-config-standard was removed from devDependencies — worth verifying lint still runs cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot convert undefined or null to object

2 participants