fix(policy): force legacy Keras for TF >= 2.16 compatibility#514
Open
thias15 wants to merge 1 commit into
Open
fix(policy): force legacy Keras for TF >= 2.16 compatibility#514thias15 wants to merge 1 commit into
thias15 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TF 2.16 switched the default Keras to Keras 3, which breaks the existing Keras 2 model definitions in
policy/openbot/models.pywiththe layer ... has never been called and thus has no defined outputfor users who deviate from the pinned 2.9.x environment.Setting
TF_USE_LEGACY_KERAS=1inpolicy/openbot/__init__.py(which runs before any submodule imports tensorflow) restores Keras 2 behavior, so policy training works on newer TF versions without forcing users to downgrade.Fixes #447. Workaround originally identified by @sparta-2024 in that issue thread.
Test plan