Open
Conversation
Fil
commented
Aug 12, 2024
Fil
commented
Aug 12, 2024
| fy: "location", | ||
| curve: "basis", | ||
| sort: "date", | ||
| fill: "color-mix(in oklab, var(--plot-background), currentColor 20%)", |
Fil
commented
Mar 19, 2026
| .call(applyDirectStyles, this) | ||
| .call(applyGroupedChannelStyles, this, channels) | ||
| .attr("fill", "none") | ||
| .attr("transform", offset ? `translate(${offset},${offset})` : null) |
Contributor
Author
There was a problem hiding this comment.
It is a bit unfortunate that we have to care for offset here; reason is that the area mark doesn't have an offset, but the line mark has one.
Fil
commented
Mar 19, 2026
| reduce: sum, | ||
| curve: "step" | ||
| }), | ||
| Plot.areaY(data, {x: "date", y: "value", interval: "day", curve: "step", fill: "#f2f2fe", line: true}), |
Contributor
Author
There was a problem hiding this comment.
this is even further simplification from #2389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a line option to the area mark makes it quite a bit more convenient to use than the areaY + lineY combo.
closes #1866 (line option on the area mark)
closes #2111 (The ridgeline plot example doesn’t handle overlapping correctly)
will need to update https://observablehq.com/@observablehq/plot-ridgeline
needs (and rebased on) #2390 (stack invalid values as NaN)