Repository navigation
docs: add native SDK usage example (#1365) - #2447
DoubleCore wants to merge 3 commits into
Conversation
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3d68be324
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uv run python -m examples.openai_sdk.chat | ||
| uv run python -m examples.openai_sdk.chat --seed |
There was a problem hiding this comment.
Require a source checkout before running the example modules
If a reader follows step 1's uv tool install path from outside a repository checkout, these commands fail with ModuleNotFoundError: No module named 'examples'. The wheel only packages src/powercontext and src/powercontext_service_bootstrap (pyproject.toml:209-210), not examples/, and uv help run states that outside a project it uses “the environment of the discovered interpreter,” not the isolated tool environment. Add an explicit checkout, cd, and uv sync prerequisite before this step in both locale guides.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This still reproduces at dec3b4dd: running the Anthropic example from outside a checkout fails with ModuleNotFoundError because the examples are not included in the installed wheel. Could you add the clone, cd, and dependency setup steps to both language guides before the example commands?
hidb4ai
left a comment
There was a problem hiding this comment.
CI preflight is failing on the new documentation files, so the downstream tests and docs checks did not run. Please fix the formatting failure and rerun the checks.
| - [API Quick Start](api-quickstart.md): capture a Source and write Memory with the HTTP API. | ||
| - [Interfaces](interfaces.md): compare the Python Client, HTTP API, and Core SDK. | ||
| - [HTTP behavior](http-api.md): authentication, request IDs, errors, and concurrency. | ||
| - [Python Agent frameworks](../integrations/index.md#python-agent-frameworks): adapters that own the model loop. No newline at end of file |
There was a problem hiding this comment.
This file is missing its final newline. The end-of-file-fixer hook fails CI preflight here and on docs/zh/docs/develop/native-sdk.md and both examples/anthropic_sdk/README files. Please run the hook and commit its fixes so the downstream checks can run.
|
Thanks — fixed the \ix end of files\ preflight failure (trailing newline normalisation on the new docs/examples) and reran the checks. All preflight hooks now pass; downstream jobs are running. |
|
Added the explicit clone + |
|
Scope clarification (self-review): issue #1365 was already closed as completed by #2010 (OpenAI Python SDK example, merged 2026-10-15), so this PR must not be read as delivering that issue. What remains unique here is the Anthropic SDK half, which #2010 does not cover: The |
hidb4ai
left a comment
There was a problem hiding this comment.
The checkout prerequisites and newline issues are addressed. The example modules start from a synced checkout, and the offline example tests pass. The current GitHub Actions run still requires action and has not run its jobs.
|
Closing this PR: the upstream issues it implements are both closed and already landed.
Keeping this open would only add review load on an already-resolved scope. Thanks to the maintainers for the review bandwidth. |
Resolves #1365