Repository navigation
feat(desktop): add Linux systemd --user service integration #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+805
−60
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
73b4029
Merge remote-tracking branch 'upstream/master' into feat/desktop-linu…
CX33071 8e32966
fix(desktop): bound diagnostic registration reads
CX33071 cdf6f91
feat(desktop): integrate Linux personal service lifecycle
CX33071 d8e816d
fix(desktop): keep macOS Ops fixtures on private temp
CX33071 fe3b7de
Merge upstream/master into feat/desktop-linux-08e
CX33071 c254b1c
fix(desktop): complete Linux resource and session support
CX33071 911d6f8
style: format managed resource preparation
CX33071 4bd2a70
fix(desktop): preserve Linux XDG service environment
CX33071 2e168b1
test(resources): run case-sensitive path regression on Linux only
CX33071 6a85f82
Merge remote-tracking branch 'upstream/master' into feat/desktop-linu…
CX33071 861dacc
fix(desktop): bound macOS workflow diagnostics
CX33071 6b2f53b
fix(gateway): add missing license header
CX33071 e4e3dd9
test(desktop): validate optional Linux CI gates
CX33071 37e1e36
ci(desktop): isolate optional Linux candidate
CX33071 05f1a55
Merge upstream/master into feat/desktop-linux-08e
CX33071 24018fb
ci(desktop): fix managed resource matrix selection
CX33071 d52ec00
ci(desktop): isolate managed resource caller concurrency
CX33071 0d7484d
Merge upstream/master into feat/desktop-linux-08e
CX33071 dcf60c3
style: format CI pipeline test
CX33071 ed2a233
Merge upstream/master into feat/desktop-linux-08e
CX33071 824e95a
docs(desktop): clarify Linux service validation
CX33071 c5b9a19
fix(desktop): preserve Linux lifecycle and XDG boundaries
CX33071 03216c2
fix(ops): align Linux XDG fallback paths
CX33071 7289b3d
fix(desktop): align Linux XDG support paths
CX33071 eb0967d
fix(desktop): preserve Linux Ops support path
CX33071 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Give the required and optional callers separate concurrency groups
Both calls inherit
managed-resource-candidates-${{ github.event.pull_request.number || github.ref }}-${{ github.event_name }}withcancel-in-progress: true, so they cancel each other despite the target split. On24018fb0, the required selector job is already cancelled with the annotationCanceling since a higher priority waiting request for managed-resource-candidates-2471-pull_request exists; its candidate matrix is cancelled too. Please distinguish the two callers in the concurrency key so optional Linux cannot preempt the required Windows/macOS qualification.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this.
The required and optional callers now use separate concurrency groups. The required Windows/macOS caller passes
concurrency_suffix: required, while the optional Linux caller passesconcurrency_suffix: linux. The suffix is included in the reusable workflow’s concurrency key, so the Linux run can no longer cancel the required candidate run.I also added regression assertions for the two caller-specific groups. The focused CI tests pass locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2 resolved at c5b9a19] The two callers now use distinct concurrency keys: the reusable group is
managed-resource-candidates-<pr|ref>-<event>-<concurrency_suffix|default>, andmaster.ymlpassesconcurrency_suffix: requiredfor the windows/macos caller andconcurrency_suffix: linuxfor the optional Linux caller. A Linux run can no longer cancel the required selection. Both callers still sharegithub.event.pull_request.number || github.refwithcancel-in-progress: true, so a re-run of the same caller still supersedes its own earlier run, which is the intended behaviour.