Repository navigation
build(desktop): assemble versioned release candidates - #2475
Merged
Merged
Conversation
knqiufan
requested review from
AlexStocks,
PsiACE and
zhanghuidinah
as code owners
November 4, 2026 17:09
…se-candidate-2112 # Conflicts: # .github/workflows/e2e-harness.yml # scripts/run_atomic_memory_clean_migration.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2112 (09-A). Reuses the managed-resource producer from #2288; publication stays in 09-B.
Desktop validation produces internal previews, and the resource producer runs separately. This adds a read-only candidate workflow that builds the normal Windows x64 NSIS and both macOS DMGs with exact Server catalog and Ops pins. The aggregate rejects missing platforms, preview/fixture inputs, and mismatched source, wheel, resource, or smoke evidence. Linux is not a dependency.
Desktop and Server source commits are pinned independently so a checked-in product record can match an already tested Server wheel. The workflow retains the full candidate and a single-file manifest artifact under distinct IDs for 09-B. It never marks candidates publishable. #2108/#2109 still own independent Ops provisioning, final catalog pins, signing, notarization and installed acceptance. #2306, #2361 and #2474 still need a jointly qualified product combination.
Validation:
uv run --no-sync pytest -q tests/test_desktop_candidate.py tests/test_managed_resource_producer.py tests/test_ops_resources.py: 66 passed, 6 native-input cases skipped. Lock, Ruff, scoped ty, workflow pins, Bash syntax and scoped Open Code Review delegation passed..DS_Storebytes; this is not a successful end-to-end candidate run. The rebuilt 09-C wheel digest differs from the historical feat(desktop): visualize current-Scope inventory and usage #2220 qualification wheel, so no historical qualification was reused.AI usage: OpenAI Codex implemented and reviewed the change with Open Code Review delegation.