Skip to content

feat(desktop): guide first use from the Overview - #2490

Merged
hireview001 merged 1 commit into
masterfrom
codex/desktop-overview-first-use
Nov 8, 2026
Merged

hireview001 merged 1 commit into
masterfrom
codex/desktop-overview-first-use

Conversation

@knqiufan

@knqiufan knqiufan commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Which issue or RFC does this PR close?

Closes #2481. Refs #2103, #2104, #2117 and #2306. Installed-platform qualification remains tracked under #2108 / #2109.

Rationale for this change

The Overview's static tutorial did not identify the next action for a disconnected user, a saved profile, an active connection without a Scope, or a selected Scope. The new guide derives those choices from current native state and follows the supplied prototype.

What changes are included in this PR?

  • Put the two-path local/existing-Server guide first, followed by a separate three-step journey and the existing capability/environment cards. Reuse theme colors and stack the layout in small windows.
  • Open the existing Local Server guidance, a new connection editor, or the exact selected saved profile. Reuse explicit activation and the shared exact-Scope picker, then continue to the existing Memory workspace.
  • Display the actual connection and complete scope_id, explain operation restrictions, and preserve recovery when the guide is dismissed. Dismissal lasts for the current Desktop session; the guide does not track first-memory completion or infer an inventory from search.
  • Preserve draft confirmation, context-pending restrictions, stale-state handling and keyboard focus. Add bilingual behavior coverage and update both Desktop READMEs.

Are there any user-facing changes?

Overview now presents contextual next actions in English and Chinese. Refresh remains an explicit action at its existing boundary.

Local installation and recovery are unavailable in the current master-based preview: View local setup opens the existing preparation guidance. Their integration remains with #2306; the existing-Server path remains usable independently. No Server API or persisted-format changes are included.

How was this change tested?

Local macOS arm64, Node 24.22.1 (the engine pin is 24.14.1), pnpm 11.13.1, Rust 1.95.0 and Python 3.14.9:

  • corepack pnpm@11.13.1 --dir desktop install --frozen-lockfile
  • Desktop lint, typecheck, test and build: passed; 199 frontend tests including 16 new Overview cases. The focused six-file selection passed 68 tests.
  • cargo +1.95.0 test --locked --manifest-path desktop/src-tauri/Cargo.toml: 131 passed, 2 opt-in tests ignored.
  • Rust formatting, all-target Clippy with -D warnings, and the generated IPC export check: passed. Native commands emit ts-rs serde-attribute parsing warnings.
  • uv run --locked pytest tests/test_desktop_contract.py -q: 3 passed.
  • make check: passed, including repository hooks, lock/policy checks, type checks and 61 integration-manifest tests.
  • Real Chromium rendering with synthetic IPC checked the initial layout, 800×600 frame viewports and a 200% layout model (400×300 CSS viewport scaled to 800×600), in Chinese/light and English/dark. Scrolled screenshots and button bounds establish layout visibility/reachability with no horizontal overflow. This is browser layout evidence, not actual OS zoom or installed WebView acceptance.
  • OCR's deterministic delegate preview/rules selected five production files; all five were reviewed. Four test files and two documentation files were also read manually. Independent review covered all eleven changed files with no remaining blocking finding.

UI tests mock native IPC. Native synthetic HTTP/process tests establish their local boundaries. This change was not exercised against an installed Windows/macOS application or a real managed installation, and does not establish signing/notarization, clean-machine acceptance, actual OS scaling, IME or screen-reader qualification. The installed-flow gates remain open.

AI usage statement

OpenAI Codex assisted with implementation, regression tests, validation and review. Open Code Review used the host-agent delegate workflow for deterministic file selection/rule resolution; an independent Codex agent reviewed the final changes and layout evidence.

@hidb4ai hidb4ai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed abb8309. No blocking findings. The state-aware guide reuses the existing connection, exact-Scope and Memory flows without adding database tables or public interfaces. Installed Windows/macOS acceptance remains tracked separately in #2108/#2109.

@AlexStocks AlexStocks added the 1.5.1 v1.5.1 release tracking label Nov 5, 2026

@knqiufan knqiufan left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this head: no blocking findings. Focused Overview tests passed with simulated IPC. GitHub does not allow the PR author to approve their own PR.

@hireview001 hireview001 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hireview001
hireview001 merged commit 6888d4b into master Nov 8, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.5.1 v1.5.1 release tracking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(desktop): guide first use from the Overview

4 participants