Repository navigation
feat(desktop): guide first use from the Overview - #2490
Merged
Merged
Conversation
knqiufan
requested review from
AlexStocks,
PsiACE and
frostming
as code owners
November 5, 2026 06:30
hidb4ai
approved these changes
Nov 5, 2026
knqiufan
commented
Nov 7, 2026
knqiufan
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed this head: no blocking findings. Focused Overview tests passed with simulated IPC. GitHub does not allow the PR author to approve their own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #2481. Refs #2103, #2104, #2117 and #2306. Installed-platform qualification remains tracked under #2108 / #2109.
Rationale for this change
The Overview's static tutorial did not identify the next action for a disconnected user, a saved profile, an active connection without a Scope, or a selected Scope. The new guide derives those choices from current native state and follows the supplied prototype.
What changes are included in this PR?
Are there any user-facing changes?
Overview now presents contextual next actions in English and Chinese. Refresh remains an explicit action at its existing boundary.
Local installation and recovery are unavailable in the current master-based preview: View local setup opens the existing preparation guidance. Their integration remains with #2306; the existing-Server path remains usable independently. No Server API or persisted-format changes are included.
How was this change tested?
Local macOS arm64, Node 24.22.1 (the engine pin is 24.14.1), pnpm 11.13.1, Rust 1.95.0 and Python 3.14.9:
corepack pnpm@11.13.1 --dir desktop install --frozen-lockfilelint,typecheck,testandbuild: passed; 199 frontend tests including 16 new Overview cases. The focused six-file selection passed 68 tests.cargo +1.95.0 test --locked --manifest-path desktop/src-tauri/Cargo.toml: 131 passed, 2 opt-in tests ignored.-D warnings, and the generated IPC export check: passed. Native commands emit ts-rs serde-attribute parsing warnings.uv run --locked pytest tests/test_desktop_contract.py -q: 3 passed.make check: passed, including repository hooks, lock/policy checks, type checks and 61 integration-manifest tests.UI tests mock native IPC. Native synthetic HTTP/process tests establish their local boundaries. This change was not exercised against an installed Windows/macOS application or a real managed installation, and does not establish signing/notarization, clean-machine acceptance, actual OS scaling, IME or screen-reader qualification. The installed-flow gates remain open.
AI usage statement
OpenAI Codex assisted with implementation, regression tests, validation and review. Open Code Review used the host-agent delegate workflow for deterministic file selection/rule resolution; an independent Codex agent reviewed the final changes and layout evidence.