Repository navigation
test(sqlite): require a captured shutdown waiter - #2496
Merged
hidb4ai merged 1 commit intoNov 5, 2026
Merged
Conversation
Make the failed-open regression fail when no worker shutdown future is observed, instead of accepting an empty list through all(). Constraint: Preserve the SQLite runtime and supported driver behavior. Scope-risk: Test assertion only; no API, storage or dependency changes. Tested: SQLite profile 47 passed each on Python 3.11, 3.12 and 3.14; missing-capture mutation fails both cases; Linux changed-file hooks and full ty check passed.
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
What changed in this PR
Strengthens the SQLite open regression test to ensure it actually observes at least one worker shutdown future before asserting those futures are complete, preventing a vacuous all(...) pass when nothing was recorded.
Changes:
- Add an assertion that at least one shutdown future (“shutdown waiter”) was captured before checking
.done()on observed futures.
| File | Description |
|---|---|
| tests/builtin/persistence/test_sqlite_profile.py | Adds a non-empty check for captured shutdown futures to avoid vacuous passing regression tests. |
Review effort: Lite
Copilot stopped reviewing on behalf of
AlexStocks due to an error
November 5, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Related to #2084. Addresses the test feedback in #2468 (discussion_r4467789901).
Rationale for this change
The failed SQLite open regression checks that every observed shutdown future is complete. An empty observation list also passes
all(...), so it could stop exercising worker cleanup without reporting a failure.What changes are included in this PR?
Require at least one observed shutdown future before checking completion. Reuse the existing real-worker read-only and writable scenarios.
Are there any user-facing changes?
Test assertion only; no runtime, API, storage or dependency changes.
How was this change tested?
pytest tests/builtin/persistence/test_sqlite_profile.py -q -W error::pytest.PytestUnhandledThreadExceptionWarning: 47 passed each on Linux Python 3.11 / 3.12 and Windows Python 3.14.ty check --python-version 3.11, changed-file prek hooks andgit diff --checkpassed. Linux hooks used an isolated environment synced from the current lock with the server extra.AI usage statement
OpenAI Codex assisted with review feedback verification, the assertion change and validation.