Repository navigation
ci: run native database acceptance nightly with reports - #2526
Conversation
hireview001
left a comment
There was a problem hiding this comment.
- CI failed: CI result (failure).
- CI failed: Upgrade release gate (failure).
- CI failed: CI preflight (failure).
- CI failed: Main (failure). Failed steps: CI preflight / Check License Header; Upgrade release gate / Require the selected parallel acceptance workflow; CI result / Require successful selected checks.
knqiufan
left a comment
There was a problem hiding this comment.
The existing acceptance-timeout finding still applies: the combined OceanBase setup, native and replay steps can consume more than the enclosing job budget, leaving no guaranteed time for evidence and cleanup. Please address the existing thread. The focused scope and workflow tests passed locally; no real OceanBase job was rerun.
hidb4ai
left a comment
There was a problem hiding this comment.
The existing P2 acceptance-timeout finding remains valid at this head. Extracting setup increases the combined step budget from 65 to 80 minutes while the OceanBase job still allows only 75 minutes, so a slow combined run can be cancelled before evidence collection and cleanup. Please make the total fit within the job deadline with time reserved for those final steps. No additional independent findings.
|
@knqiufan, in response to your review: fixed in 342cf9ad. The OceanBase job now allows 90 minutes, covering 15 minutes of startup, 50 minutes of native acceptance and 15 minutes of replay, with 10 minutes reserved for diagnostics, evidence and cleanup. A regression check protects that reserve for all three selection modes. I also replied in the original inline thread. Local checks pass; the new CI run is still in progress, so real OceanBase acceptance is not yet confirmed. |
|
@hidb4ai, in response to your review: addressed in 342cf9ad. The combined workload's 80-minute step budget now fits within a 90-minute job deadline, leaving 10 minutes for diagnostics, evidence and cleanup. The workflow comment and regression checks reflect this allocation. The branch also includes #2515's fixes and repairs the cross-step container/deadline handoff and JUnit upload path. Local validation passes; the new CI run is still in progress. |
|
@hireview001, following up on your CI failure review after the new run 42380905358 completed for The previous run failed when installing The upgrade gate records The CI issue is not yet verified as resolved. License-tool setup must complete successfully before the remaining acceptance can be validated. |
|
@Zxf-xufeng plz fix the ci failure. |
…ase-ci # Conflicts: # .github/workflows/e2e-harness.yml
|
@hireview001 Following up on the earlier CI failure notice, now that the verification run has finished: The reported license-header stage passed in CI preflight. The complete scan found no invalid headers; the scan budget now accommodates its measured three-minute runtime. The overall run is still red for a different reason: Python 3.14 E2E hit the Gateway fixture's 300-second build limit while downloading Rust dependencies. Its 34 setup errors share that cause; the downstream upgrade and final gates correctly failed because acceptance could not run. Commit 0eacec4 adds a cached, separately bounded Gateway prebuild before pytest and reserves time for the build, tests, and cache cleanup. The new CI run is pending verification, so I am not claiming the overall CI failure is resolved yet. |
hidb4ai
left a comment
There was a problem hiding this comment.
Re-reviewed at 0eacec40. My previous acceptance-timeout objection is addressed: the bounded OceanBase steps total 117 minutes within a 125-minute job, and SQLite replay has 40 minutes within a 50-minute job. I found no additional confirmed correctness defect.
Validation remains incomplete: Main run 42776126403 was cancelled, with harness and upgrade acceptance skipped. Local review also hit the existing test_oceanbase_compose_does_not_start_server_after_migration_failure[verify] test's 60-second deadline twice on this head; the base completed in 52.7 seconds. I cannot attribute that timing failure to this patch. The real seekDB query checks do not establish OceanBase or complete replay/upgrade acceptance.
…into codex/nightly-database-ci
Bring in the 6 first-parent commits that landed since the previous merge, including the OpenDAL fix for the Pydantic diagnostic that failed `opendal-package` on this branch and on master (oceanbase#2503), the Pi extension tests against a real Server (oceanbase#2531), and the harness workflow restructuring (oceanbase#2526). The merge is textually clean. The persistence digest in `release/upgrade-support.json` is unchanged. The new Pi service chain test passed the removed `scheduler_path` argument to `create_server_app`, so that argument is dropped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Post-merge re-review of The first scheduled Main run finished with 90 successful, 13 skipped and 6 failed jobs. All 12 upgrade cases passed, and the OceanBase native acceptance step passed all 22 selected tests. The report workflow also succeeded and correctly preserved Main's failure. Scheduling and reporting now have actual execution evidence, but full acceptance is still incomplete. Remaining CI follow-up:
Please verify these follow-ups in a complete scheduled or manual run before treating nightly acceptance as green. |
|
Follow-up to the previous verification note: #2526 remains unchanged at The later manual Main run at Full acceptance remains incomplete for different failures:
The report workflow succeeded and preserved Main's failure. Please investigate these failures on the later commit and obtain a complete passing run. They are not established regressions introduced by #2526; the original timeout finding remains resolved. |
Which issue or RFC does this PR close?
Consolidates the database CI reliability work from #2515. No issue is automatically closed.
Rationale for this change
Running seekDB and OceanBase matrices on every PR and master push creates a backlog of expensive database jobs. Keep SQLite feedback on ordinary changes and run native database acceptance once per night, while preserving mandatory results for every selected workload.
What changes are included in this PR?
ci:fullcannot enable native database jobs on these events.0 18 * * *schedule (02:00 Asia/Shanghai; 18:00 UTC) runs full database acceptance, including seekDB startup/migrations, OceanBase recovery/FTS/migration shards, native acceptance, all 12 upgrade configurations, all backend schema replays/captures and short lock probes. Explicit manual runs remain available; extended lock observation remains manual.sqliteupgrade subset records deferred cases and cannot authorize publication or produce publication artifacts. Release acceptance retains the full matrix.The branch includes master commit
c919c0e2d. The final diff is limited to database CI, supporting scripts, test fixtures and documentation; production runtime, integrations, Gateway, Desktop and release compatibility metadata match that master commit.Are there any user-facing changes?
PR and master-push database checks use SQLite; seekDB and OceanBase acceptance runs nightly or manually. Scheduled validation uses the default branch and takes effect after merge. A nightly result is not evidence for an unmerged PR head. Public APIs and persisted formats are unchanged.
How was this change tested?
make checkand the finaluv run prek run -a: passed.actionlintv1.7.12 on all six changed workflows: passed. Repository action-pin validation: passed.make checkpassed, including 61 integration-manifest checks.42744760796: all 94 jobs captured (60 success, 21 failure, 13 skipped), with the source failure preserved. This validates metadata collection/rendering, not deployment of the new workflow listener.AI usage statement
OpenAI Codex assisted with analysis, implementation, conflict/integration review, regression tests and PR preparation.