Repository navigation
docs(rfc): propose scope-based knowledge bases - #2570
Open
Zxf-xufeng wants to merge 10 commits into
Open
Zxf-xufeng wants to merge 10 commits into
Zxf-xufeng wants to merge 10 commits into
Conversation
hidb4ai
approved these changes
Nov 11, 2026
hidb4ai
left a comment
Contributor
There was a problem hiding this comment.
No blocking design issues found at 71e842c. This approval covers the bilingual RFC only; the three plugin domain tables and plugin APIs remain proposed implementation work. Current CI is incomplete because preflight was cancelled, so this approval does not clear the CI gate or establish runtime, OCR, or three-backend acceptance.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Related to #2440, #2441, #2442, #2443, and #2444. This design-only PR does not close implementation issues. Framework contracts are defined in #2549 and #2579, with implementation in #2616. Source collection in #2617 is a future integration, not a first-phase requirement.
Rationale for this change
Provide document knowledge bases through one single-family business plugin: one ordinary Scope is one knowledge base, and each document Artifact represents a whole file. Reuse framework Source consumption, synchronous user changes, and native lifecycle semantics while keeping immutable chunks and search indexes in plugin storage.
What changes are included in this PR?
Only the English and Chinese RFCs under
docs/{en,zh}/rfcs/2570-knowledge-base.md:knowledge-baseplugin declares thedocumentfamily, original-file and processing-request Source definitions, APIs, rendering, and search. Knowledge bases are Scopes rather than another Artifact family.generate, Supervisor, and consumption cursors. Deterministic input failures can be recorded and skipped; infrastructure failures roll back the window and use framework retry. Status observations do not replace committed core results.lineage_onlyevidence with revision preconditions.forget: deprecated and excluded from normal retrieval, without a new content revision or plugin deletion evidence. Originals, bodies, and authorized history remain available. No Source deletion, in-flight cancellation, knowledge-base cascade, or implicit restoration through reimport.server.admin; plugin configuration retries after Scope creation, migrations useupgrade(ctx), and first-phase deployments may restart rather than require hot reload.Are there any user-facing changes?
Documentation only. No runtime, dependency, OpenAPI, migration, or generated-site files change. The proposed first phase includes all three database backends, synchronous manual chunk editing, and native document soft deletion. It does not promise that forgetting a document revokes historical access or deletes its Source. Framework proposals are not treated as already implemented capabilities.
How was this change tested?
git diff --checkandgit diff --cached --check.UV_OFFLINE=1 uv run --locked prek run -acould not start because Pillow 12.3.0 was absent from the local cache. Full hooks/type checks and the full website build are not verified. These documentation checks do not establish runtime, OCR, concurrency, or real database support.AI usage statement
OpenAI Codex inspected the framework contracts, drafted the English RFC and Chinese translation from the requester's confirmed decisions, and ran focused documentation checks.