Repository navigation
test(desktop): verify the installed connection and Scope journey - #2581
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
hidb4ai
left a comment
There was a problem hiding this comment.
Reviewed f6571ba. No blocking findings. The installed connection/Scope journey and pre-extraction wheel validation address the stated acceptance gaps without adding database tables or product interfaces. Hosted Windows installed evidence covers the new journey; clean Windows 11/macOS release qualification remains tracked separately.
Which issue or RFC does this PR close?
Refs #2101 and #2103. Local setup handoff is being delivered in #2306. Windows 11 and macOS installed qualification remains tracked in #2108/#2109.
Rationale for this change
The installed workflow activates saved profiles immediately and uses a single matching Scope title. It therefore misses regressions where saving/checking activates a connection, title-based selection targets the wrong Scope, or ordinary operations invoke readiness. The installed Server fixture also extracts its wheel before verifying that it matches the qualification used by the native client.
What changes are included in this PR?
/health/readyendpoint. Ordinary UI operations preserve the startup count and the explicit probe adds exactly one request. Save successful observations inconnectionJourneyin the existing installed UI report.desktop/VALIDATION.md.Are there any user-facing changes?
This change extends acceptance tooling for existing Server connections. The new scenario runs through packaged UI controls and native transport on the disposable Windows runner.
How was this change tested?
Local Windows 10 x64 / Python 3.11.15, based on master
cc752d8accb0bc4ffade2d4b84ef6e48206e122d.uv run --no-sync pytest tests/test_desktop_contract.py tests/test_desktop_fixture_qualification.py -qpasses 11 tests.pnpm --dir desktop testpasses 211 frontend tests with mocked IPC.server_probeand the existingreal_server.pyharness pass all four SQLite modes after the proxy instrumentation change.cc752d8a. All 745 runtime files match after CRLF normalization. Wheel SHA-256 isdf51abf71e54bd857962ed171cc8fe37a1f28182e8ccd8fc2851d37595dc4ec4.68b91ce9merges the Desktop changes cleanly. It encounters an existing ZCode test conflict between that branch and current master.The new installed WebView2 scenario requires the hosted Windows CI run. Local HTTP and mocked-IPC results leave that scenario NOT_RUN locally. Windows 11/macOS release qualification remains pending in the platform tasks.
AI usage statement
OpenAI Codex assisted with implementation, regression reproduction, real Server validation and documentation.