Repository navigation
Conversation
hidb4ai
requested review from
AlexStocks,
PsiACE,
frostming and
zhanghuidinah
as code owners
November 13, 2026 06:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Related failure run: OceanBase nightly CI.
Rationale for this change
The nightly run failed in three different phases: a background CLI exceeded its startup deadline, a passing concurrent-startup case exhausted its process budget during database cleanup, and the native metrics CLI exceeded its 360-second migration deadline. Repeated full-schema reflection adds work to initialization, while workflow-level diagnostics arrive too late for an inner CLI timeout.
What changes are included in this PR?
Are there any user-facing changes?
OceanBase initialization and startup perform fewer redundant metadata reads. Public APIs, registered database layouts, frozen migrations, persisted formats and the required upgrade matrix are unchanged. Schema drift on an unrelated table during maintenance is still rejected before domain writes or version advancement; concurrent external schema changes remain outside the maintenance contract.
How was this change tested?
make check: passed, including hooks, type checks, lock/release checks and 61 integration-manifest tests.python -m pytest tests/test_oceanbase_ci.py -q: 41 passed, covering separate phase deadlines, pre-timeout stacks, exit cleanup and cancellation of descendants. The six affected cases also passed after the final type-annotation adjustments.python -m pytest tests/test_ci_changes.py -q: 154 passed.ghcr.io/oceanbase/oceanbase-ce:4.3.5.6-106000012026040916and capacity settings: all three original failing cases passed without skips, including database cleanup. The native CLI apply completed in 199.81 seconds under its unchanged 360-second limit.A single sequential baseline/candidate measurement on the same host and container, with separate fresh databases, reduced
runner.applyfrom 346.907 to 185.701 seconds andSHOW CREATE TABLEcalls from 9,197 to 3,974. Counts for other statement categories were unchanged. This measures migration only, excluding imports, database creation, planning, cleanup and complete service startup.The local Python minor versions match CI, but patch versions and machine load differ. These measurements do not establish GitHub runner or queue-time savings. The candidate's full GitHub workflow and all 12 installed-release upgrade combinations have not been run.
AI usage statement
Implemented and validated with OpenAI Codex, including code review and local native-backend probes.