[IMP]: knowledge tour added via script#7
Open
aycha-odoo wants to merge 1 commit into
Open
Conversation
chga-odoo
reviewed
May 13, 2026
chga-odoo
left a comment
chga-odoo
left a comment
There was a problem hiding this comment.
@aycha-odoo just one suggetion.
Thanks!
Comment on lines
+643
to
+657
| knowledge_tour_path = Path(destination_module_path + '/data/knowledge_tour.xml') | ||
| knowledge_tour_path.parent.mkdir(parents=True, exist_ok=True) | ||
|
|
||
| knowledge_tour_content = f"""<?xml version='1.0' encoding='UTF-8'?> | ||
| <odoo noupdate="1"> | ||
| <record id="knowledge_tour" model="web_tour.tour"> | ||
| <field name="name">{self.ind_name}_knowledge_tour</field> | ||
| <field name="sequence">2</field> | ||
| <field name="rainbow_man_message">Welcome! Happy exploring.</field> | ||
| </record> | ||
| </odoo> | ||
| """ | ||
|
|
||
| knowledge_tour_path.write_text(knowledge_tour_content, encoding="utf-8") | ||
|
|
There was a problem hiding this comment.
Please wrap this logic into a separate function to improve modularity, code readability, and maintainability. It will also make the flow easier for developers to understand.
suggest same changes for only_cleanup_script.py file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added knowledge tour XML generation in cleanup script