[IMP] empty#5131
Draft
lebm-odoo wants to merge 4 commits into
Draft
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
Previously, the 'New Contract' widget was visible even if the employee had no contract dates. This was caused by a missing visibility condition. This commit adds the 'invisible' attribute to the widget to ensure it only appears when 'contract_date_start' is set. Task: 6186258
Prevent selection of invalid dates (e.g., Feb 31st) by introducing the 'accrual_selection_day' widget. The widget uses 'extractProps' to read a 'month_field' from XML options and dynamically filters the day selection list based on the chosen month's length. Task: 6197119
Steps to reproduce: 1. Go to Time Off > Configuration > Time Off Types. 2. Open any type and click the 'Time Off' smart button. 3. Click 'New' or attempt to filter/search on the resulting view. 4. A TypeError occurs during the evaluation of the remaining leaves. Bug: In `_search_virtual_remaining_leaves`, the operator `op` was being called without its second argument (the comparison value). Solution: Pass the comparison value to the operator in `_search_virtual_remaining_leaves` to ensure the comparison is evaluated correctly and prevent the TypeError. task: 6194971
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.