[IMP] empty#5135
Draft
lebm-odoo wants to merge 3 commits into
Draft
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
In the employee view > payroll_informations : BEFORE: The button "New Contract" was displayed unconditionnally AFTER: Since it makes no sense to start a contract without a start date, that button will only appear when the start date is defined task-6186027
Bug introduced: Introduced by commit: 6485081 --- Step to reproduce: 1. Make sure the employee has at least one time off allocation (work_entry with requires_allocation set to True). In-app : TIME OFF > Management > Allocations > New... 2. Create a time off for that employee and try to select the Time Type In-app: TIME OFF > Management > Time Off > New > Select employee + Select Time Type Reason: Syntax error - one argument was passed to a method instead of two The method was only called by an domain RPC search in the form. Solution: Added the second parameters in the method call --- Task #6187725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.