[FIX] hr_holidays: Traceback on Time Off Type#5154
Open
raame-odoo wants to merge 1 commit intomaster-hr-onboarding-raamefrom
Open
[FIX] hr_holidays: Traceback on Time Off Type#5154raame-odoo wants to merge 1 commit intomaster-hr-onboarding-raamefrom
raame-odoo wants to merge 1 commit intomaster-hr-onboarding-raamefrom
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-raame, it needs to be retargeted before it can be merged. |
raame-odoo
force-pushed
the
master-hr-onboarding-traceback_timeoff_type-raame
branch
from
1ca061b to
32a245b
Compare
When navigating (Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type), it leads to an error. The nested function is_valid in function _search_virtual_remaining_leaves in hr_work_entry_type uses an operator in it's return statement that has on parameter when it should receive two parameters. the second parameter "value" was added. Task: 6197121
raame-odoo
force-pushed
the
master-hr-onboarding-traceback_timeoff_type-raame
branch
from
32a245b to
d886614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating (Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type), it leads to an error. The nested function is_valid in function _search_virtual_remaining_leaves in hr_work_entry_type uses an operator in it's return statement that has on parameter when it should receive two parameters. the second parameter "value" was added.
Task: 6197121