Skip to content

fix(deps): update dependency tempy to v3.2.0#784

Open
renovate[bot] wants to merge 2 commits intomasterfrom
renovate/tempy-3.x
Open

fix(deps): update dependency tempy to v3.2.0#784
renovate[bot] wants to merge 2 commits intomasterfrom
renovate/tempy-3.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Feb 2, 2026

This PR contains the following updates:

Package Change Age Confidence
tempy 3.1.23.2.0 age confidence

Release Notes

sindresorhus/tempy (tempy)

v3.2.0

Compare Source

  • Add rootDirectory option 71cbe20
  • Add parentDirectory option 0107c8d
  • Increase cleanup retry attempts to handle Windows file locking 53b1211


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@olexs
Copy link
Copy Markdown
Owner

olexs commented Feb 2, 2026

@claude The Renovate PR build failed (workflow run: 21602402270).

Please analyze the CI failure and implement a fix if possible.

Workflow run: https://github.com/olexs/pdf-assembler/actions/runs/21602402270

@claude
Copy link
Copy Markdown

claude bot commented Feb 2, 2026

Claude finished @olexs's task in 8m 14s —— View job


CI Failure Analysis Complete

  • Fetch CI workflow run details and logs
  • Analyze the failure and identify root cause
  • Investigate tempy 3.2.0 module resolution
  • Implement fix
  • Run pre-commit checks (lint, test, package)
  • Commit and push changes

Root Cause

The E2E tests were failing because tempy 3.2.0 introduced new code paths that call fs.mkdirSync():

  • New resolveParentDirectory() function for the parentDirectory option
  • New validation logic in getPath() for the rootDirectory option

These functions use node:fs imports, which webpack was potentially aliasing to pdfkit's virtual-fs.js in the renderer bundle. The virtual-fs only implements readFileSync and writeFileSync, causing the app to crash immediately on startup when tempy tried to call the missing mkdirSync method.

Solution

Updated webpack.renderer.config.js to explicitly exclude node:fs and node:fs/promises from the fs alias:

alias: {
  fs: 'pdfkit/js/virtual-fs.js',
  // Exclude node:fs from aliasing to allow tempy to use real fs module
  'node:fs': false,
  'node:fs/promises': false
}

This allows tempy to access the real Node.js fs module (including mkdirSync) while pdfkit continues to use the virtual-fs for its own file operations.

Pre-commit Checks

  • ✅ Lint: Passed
  • ✅ Unit tests: Passed (83 tests)
  • ✅ Package: Successful
  • ⏳ E2E tests: Will be verified by CI

Changes Pushed

Committed and pushed the webpack configuration fix to the renovate/tempy-3.x branch. CI will now run the E2E tests to verify the fix works on both macOS and Windows.


| Branch: renovate/tempy-3.x

Tempy 3.2.0 added new code paths that call fs.mkdirSync() in the
resolveParentDirectory function and getPath function. These calls use
'node:fs' imports which were being caught by webpack's fs alias to
pdfkit's virtual-fs.js in the renderer bundle.

The virtual-fs only implements readFileSync and writeFileSync, causing
the app to crash when tempy tries to call mkdirSync.

This fix explicitly excludes 'node:fs' and 'node:fs/promises' from
the fs alias, allowing tempy to use the real Node.js fs module while
pdfkit continues to use the virtual-fs.

Fixes E2E test failures on macOS and Windows.

Co-authored-by: Olex S. <olexs@users.noreply.github.com>
@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Feb 2, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant