Conversation
|
Claude finished @nialexsan's task in 1m 54s —— View job Code Review
Good PR overall — the architecture is clean and the test coverage is solid. A few items worth addressing: Potential Issues1. The Dockerfile copies the entire repo into the image, which includes Fix: add a 2. SIGPIPE inconsistency in
# Current (line 767) — has SIGPIPE risk
if ! echo "$result" | grep -q "SEALED" || echo "$result" | grep -q "Transaction Error"; thenThis should use 3. The test job only runs # test job should be:
permissions:
contents: read4. Fragile vault ID parsing in echo "$result" | grep -oE '\b[0-9]+\b' | sort -n | tail -1This extracts every number from the script output and takes the largest. If the script output format changes (e.g., prints a timestamp or block height), this silently returns the wrong ID and the test continues without error. Consider having the script print the vault ID on a dedicated line with a known prefix and parsing that instead. 5.
Minor Observations
What's Working Well
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Closes: https://github.com/onflow/FlowYieldVaults-fe/issues/139
Description
build container with forked mainnet emulator for e2e tests in backend and frontend repos
successful build run https://github.com/onflow/FlowYieldVaults/actions/runs/24156458638/job/70496636491
For contributor use:
masterbranchFiles changedin the Github PR explorer