Repository navigation
add n_dims parameter to Backend.__init__ - #1964
Conversation
…etup initial n_dims for kinematic 1D and 2D usages
|
@slayoo https://github.com/open-atmos/PySDM/actions/runs/37615388765/job/112776720241#step:4:2687 According to our change in #1885, we can't reuse environment instances for multiple particulators. EDIT: II think we should change assert there |
|
So, it is interesting... I fixed this issue by reverting unintended change in the value of "n_dims". Previously in this test it was set to 0 (I set it to 2 because of the grid size). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 429 429
Lines 11138 11140 +2
=======================================
+ Hits 9742 9744 +2
Misses 1396 1396 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Kudos @AgnieszkaZaba ! Since this is aimed at closing #1179, we need to also remove the TODO label here: |
#1179