Skip to content

Re-vendor the 0.7.7 preview from forge-cli v0.32.0 - #56

Merged
fas89 merged 2 commits into
mainfrom
chore/revendor-forge-0.32.0
Nov 18, 2026
Merged

fas89 merged 2 commits into
mainfrom
chore/revendor-forge-0.32.0

Conversation

@fas89

@fas89 fas89 commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Moves the pin from forge-cli v0.31.0 to v0.32.0 (peeled commit 8ad55d53987157bac4b0fa1a8004bdfd00b3ca9d). Only the 0.7.7 preview changed: 0.7.2 to 0.7.6 are byte-identical at the new tag and are not touched.

What changes

  • Schema: fluid-schema-0.7.7.json is replaced byte for byte from the tag (297933 bytes). Two lines differ from the v0.31.0 copy: the column type description and its pattern. scripts/schema-versions.json moves ref and commit.
  • Generated output: specs/0.7.7 and schema-diffs/diff-0.7.6-to-0.7.7.md are regenerated with the locked renderer.
  • What 0.7.7 gained since the v0.31.0 copy: an enum column type can name quoted levels, such as enum('Dr.', '>10000', 'O''Brien', 'a, b'). A level is a word list or a quoted string that may hold any character but a control character, with its own quote doubled as SQL writes it.
  • Corpus: seven cases in tests/0.7.7/contract-schema.json, three valid and four invalid. Six of them get the other verdict under the v0.31.0 copy, so they fail without this change.
  • Docs: docs/releases/0.7.7.md (a new Enum levels section), docs/releases/README.md and docs/schema/changelog.md say the pair now has two narrowings. The release note's complete contract is re-checked with data-product-forge 0.32.0.
  • tests/README.md: the coverage figure for 0.7.7 was stale (48.2%). Measured on main and on this branch alike, it is 41.4%.

The enum pattern narrows at its edge

  • The new pattern reads an enum's parameters as a list of levels. 0.7.6 took any run of letters, digits, underscores, spaces, commas, quotes and hyphens. Every other type keeps that character set.
  • scripts/check-compat.py reports the changed pattern at /$defs/column/properties/type/anyOf/1, so it is waived in scripts/compat-waivers.txt (kept sorted). The waiver carries the evidence: I compared the two patterns on 1,195,741 strings, and again on 618,821 more that include control characters and a non-ASCII letter. No type other than enum changes its verdict.
  • 0.7.6 accepts and 0.7.7 now refuses: an empty item (enum(a,,b)), a quote that does not open and close a level (enum('it's'), enum('a' 'b')), and a tab, a newline or another whitespace control character inside a quoted level. 21,676 strings in the first run.
  • 0.7.6 refuses and 0.7.7 now accepts: an enum with a quoted level that holds a character 0.7.6 refused, such as a full stop, a comparison sign or a non-ASCII letter. 960 strings in the first run.
  • 0.7.7 is a preview, and a contract reaches it only by declaring "0.7.7". The release note and the changelog say the pair is not purely additive.
  • tests/meta_test.py changes in one place. Its waiver test put its sample entry before the last 0.7.6 to 0.7.7 line, which broke the sort order once that pair had two entries. It now goes before the first.

Checks (all pass)

  • meta_test: 50/50.
  • conformance/run.py: 1965/1965 (1958 before, plus the seven new cases).
  • check-compat: compatible, and 0.7.6 to 0.7.7 has 2 waived.
  • check-schema-drift: pass against v0.32.0, and --latest finds no newer release.
  • generate-docs.py --check and generate-schema-diffs.py --check: pass.
  • mutation_coverage, floor 40: 0.7.5 41.0% (432 of 1053), 0.7.6 45.7% (570 of 1248), 0.7.7 41.4% (638 of 1541), the same as on main. The full 0.7.5 run exits 0. I ran 0.7.6 and 0.7.7 as 12 slices of the mutation list and summed them, because the full runs crawled on a busy machine; the same slicing reproduces the full 0.7.5 run exactly. CI runs the unsliced gate.
  • check_reference against data-product-forge 0.32.0: 1959 agree, 0 disagree, 6 optional behaviours not implemented.
  • docs-links grep: clean. npm run docs:build (npm 10.9.4): builds.
  • data-product-forge 0.32.0 validates the release note's complete contract (it prints the valid line, with one warning about the example.com owner address in that contract).

For the maintainer

Keep a second waiver for the enum pattern, or ask forge-cli to keep the old enum spellings?

The vendored 0.7.7 schema was the v0.31.0 copy. Replace it with the
reference implementation's file at the v0.32.0 tag, byte for byte, and
regenerate what derives from it: specs/0.7.7/ and
schema-diffs/diff-0.7.6-to-0.7.7.md. 0.7.2 to 0.7.6 are byte-identical
at the new tag.

Only the column type changed. An enum can now name quoted levels, such
as enum('Dr.', '>10000', 'O''Brien', 'a, b'). Its pattern narrows at the
edge: an empty item, a quote that does not open and close a level, and a
tab, a newline or another whitespace control character inside a quoted
level are refused, and 0.7.6 accepted them. check-compat reports the
changed pattern, so scripts/compat-waivers.txt records it, with the
comparison of the two patterns that settled it.

tests/meta_test.py put its sample waiver before the last entry of the
0.7.6 to 0.7.7 pair, which kept the file sorted only while the pair had
one entry. It now goes before the first. The 0.7.7 corpus gains seven
enum cases, three valid and four invalid.

upstream.ref is v0.32.0 and upstream.commit is the tag's peeled commit,
8ad55d53987157bac4b0fa1a8004bdfd00b3ca9d.
The release note, the releases index and the changelog said the 0.7.7
preview had one narrowing, in secret references. It has a second, at the
edge of the enum column type. Add an Enum levels section to the release
note, with the spellings each version accepts, correct the reading
paragraph of the releases index, and move the complete contract's
validation claim to data-product-forge 0.32.0.

tests/README.md carried a stale coverage figure for 0.7.7. Measured on
the base commit and on this branch alike, it is 41.4% (638 of 1541
constraints, 141 redundant), so the figure is corrected, and the README
says why the seven new enum cases exist.
@fas89
fas89 merged commit d856e83 into main Nov 18, 2026
7 checks passed
@fas89
fas89 deleted the chore/revendor-forge-0.32.0 branch November 18, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant