Repository navigation
Re-vendor the 0.7.7 preview from forge-cli v0.32.0 - #56
Merged
Merged
Conversation
The vendored 0.7.7 schema was the v0.31.0 copy. Replace it with the
reference implementation's file at the v0.32.0 tag, byte for byte, and
regenerate what derives from it: specs/0.7.7/ and
schema-diffs/diff-0.7.6-to-0.7.7.md. 0.7.2 to 0.7.6 are byte-identical
at the new tag.
Only the column type changed. An enum can now name quoted levels, such
as enum('Dr.', '>10000', 'O''Brien', 'a, b'). Its pattern narrows at the
edge: an empty item, a quote that does not open and close a level, and a
tab, a newline or another whitespace control character inside a quoted
level are refused, and 0.7.6 accepted them. check-compat reports the
changed pattern, so scripts/compat-waivers.txt records it, with the
comparison of the two patterns that settled it.
tests/meta_test.py put its sample waiver before the last entry of the
0.7.6 to 0.7.7 pair, which kept the file sorted only while the pair had
one entry. It now goes before the first. The 0.7.7 corpus gains seven
enum cases, three valid and four invalid.
upstream.ref is v0.32.0 and upstream.commit is the tag's peeled commit,
8ad55d53987157bac4b0fa1a8004bdfd00b3ca9d.
The release note, the releases index and the changelog said the 0.7.7 preview had one narrowing, in secret references. It has a second, at the edge of the enum column type. Add an Enum levels section to the release note, with the spellings each version accepts, correct the reading paragraph of the releases index, and move the complete contract's validation claim to data-product-forge 0.32.0. tests/README.md carried a stale coverage figure for 0.7.7. Measured on the base commit and on this branch alike, it is 41.4% (638 of 1541 constraints, 141 redundant), so the figure is corrected, and the README says why the seven new enum cases exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pin from forge-cli v0.31.0 to v0.32.0 (peeled commit 8ad55d53987157bac4b0fa1a8004bdfd00b3ca9d). Only the 0.7.7 preview changed: 0.7.2 to 0.7.6 are byte-identical at the new tag and are not touched.
What changes
The enum pattern narrows at its edge
Checks (all pass)
For the maintainer
Keep a second waiver for the enum pattern, or ask forge-cli to keep the old enum spellings?