chore: resolve open dependabot security alerts#421
Conversation
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including upgrading serialize-javascript to version 7.0.5 and @tootallnate/once to version 3.0.1, while adding minimatch and removing randombytes. Feedback highlights that the serialize-javascript upgrade introduces a breaking requirement for Node.js 20.0.0, which may impact environments on older LTS versions. Additionally, it is recommended to use caret ranges instead of the >= operator in the dependency overrides to ensure stability and prevent unintended major version upgrades.
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds npm overrides to mitigate several Dependabot security alerts by forcing patched versions of vulnerable transitive dependencies.
Changes:
- Added overrides for
serialize-javascript,@tootallnate/once,fast-uri, and@babel/plugin-transform-modules-systemjs. - Kept existing
test-excludeoverride (withminimatch) and extended the override list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Adds overrides in
package.jsonto require at least the patched version of transitive dependencies (within the current major). Note:webpack-dev-serveralerts (#69, #70) require a major upgrade (4.x → 5.x) — blocked by@nx/webpack@17.3.2which requireswebpack-dev-server ^4.9.3.Dependabot Alerts Resolved
serialize-javascriptserialize-javascript@tootallnate/oncefast-urifast-uri@babel/plugin-transform-modules-systemjsUnresolvable Alerts
webpack-dev-server@nx/webpack@17.3.2requires^4.9.3; major upgrade needed