Skip to content

fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathannorris wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4 #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d38367d
fix(flagd-provider): update fractional targeting test expectations fo…
jonathannorris Apr 28, 2026
50386f8
fix(flagd-provider): use distinct-variant targeting keys for fraction…
jonathannorris Apr 28, 2026
e87ec35
Merge branch 'main' into fix/flagd-fractional-test-expectations
josecolella May 12, 2026
b243030
fix(otel-hook): update bundler to 4.0.11 for Ruby head compatibility
jonathannorris May 12, 2026
d88f649
ci: mark test_otel_hook (head) as non-blocking
jonathannorris May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,12 @@ jobs:

test_otel_hook:
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.ruby-version == 'head' }}
defaults:
run:
working-directory: ./hooks/openfeature-otel-hook
strategy:
fail-fast: false
matrix:
ruby-version:
- "3.4"
Expand Down
2 changes: 1 addition & 1 deletion hooks/openfeature-otel-hook/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ DEPENDENCIES
standard (~> 1.0)

BUNDLED WITH
2.7.1
4.0.11
8 changes: 4 additions & 4 deletions providers/openfeature-flagd-provider/spec/openfeature/flagd/provider_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,10 @@
)
end

expect(fetch_value_with_targeting_key.call("1234")).to eq("#b91c1c")
expect(fetch_value_with_targeting_key.call("qwe")).to eq("#0284c7")
expect(fetch_value_with_targeting_key.call("abcd")).to eq("#16a34a")
expect(fetch_value_with_targeting_key.call("rfv")).to eq("#b91c1c")
expect(fetch_value_with_targeting_key.call("alice")).to eq("#b91c1c")
expect(fetch_value_with_targeting_key.call("bob")).to eq("#0284c7")
expect(fetch_value_with_targeting_key.call("charlie")).to eq("#16a34a")
expect(fetch_value_with_targeting_key.call("dave")).to eq("#4b5563")
end
end

Expand Down
Loading