fix: update npm package name and Node version; test: implement memory and telemetry tests#54
Open
Oxygen56 wants to merge 2 commits into
Open
fix: update npm package name and Node version; test: implement memory and telemetry tests#54Oxygen56 wants to merge 2 commits into
Oxygen56 wants to merge 2 commits into
Conversation
- install.sh: Update Node.js version check from >=18 to >=20 to match package.json engines field - Documentation.md: Update version string from 1.3.3 to 1.5.2 and npm update command to use scoped package @open-gitagent/gitagent - README.md: Update Node.js requirement from 18+ to 20+ in install instructions and FAQ, fix npm badge to use scoped package name - tsconfig.json: Exclude __tests__ directories from compilation Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- src/tools/__tests__/memory.test.ts: Replace 3 it.todo() stubs with 7 real tests covering load, save (with git commits), default message, content validation, and abort signal handling - src/__tests__/telemetry.test.ts: Replace 2 it.todo() stubs with 4 real tests covering initTelemetry behavior without endpoint, with _testProvider, idempotency, and shutdown state reset Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes:
1. Bugfixes
gitagent→@open-gitagent/gitagent) and incorrect Node.js version check (≥18 → ≥20 to match package.json engines field)2. Tests
it.todo()stubs — covering load (stored content, empty/missing file, heading-only file), save (writes content+git commit, default message, content required validation), and abort signal handlingit.todo()stubs — covering graceful init without endpoint, init with test provider, idempotency, and shutdown state resetTest Plan
tsc