Repository navigation
Remove disk-buffering benchmark - #3191
Merged
Merged
Conversation
LikeTheSalad
approved these changes
Oct 30, 2026
LikeTheSalad
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @jaydeluca
Tbh I forgot about this benchmark when adding the changes. I don't need it so I'm fine with removing it, and since it has been failing for so long without someone complaining, I don't think it would be missed. But I also don't have strong opinions on either option so, if there's some policy or pattern expected from modules to have some benchmarks or the like, it's fine for me as well if it stays.
Member
Author
|
@LikeTheSalad i'll remove it instead since it doesn't feel necessary, at least for now |
Contributor
Thanks again for taking a look into this. |
jaydeluca
enabled auto-merge
October 30, 2026 13:29
jaydeluca
disabled auto-merge
October 30, 2026 13:29
laurit
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
disk-buffering:compileJmhJavatask doesn't currently compile.FileTransferUtilBenchmarkimportsFileTransferUtil, which #1917 removed whenReadableFilemoved to an in-placeFileStream.truncateTop().This replaces it with
FileStreamBenchmark, which benchmarksFileStream.truncateTop(long)on a 1MB file, the operation that took over fromFileTransferUtil.transferBytes. BecausetruncateTopchanges the file, the file is rewritten and reopened before each invocation (Level.Invocation), outside the measured time.I assumed this might be more useful than just deleting it outright, but we don't seem to be running them in CI anyway so if we think we should just remove it, that works too.