Skip to content

Remove disk-buffering benchmark - #3191

Merged
jaydeluca merged 3 commits into
open-telemetry:mainfrom
jaydeluca:update-benchmark
Nov 17, 2026
Merged

jaydeluca merged 3 commits into
open-telemetry:mainfrom
jaydeluca:update-benchmark

Conversation

@jaydeluca

Copy link
Copy Markdown
Member

The disk-buffering:compileJmhJava task doesn't currently compile.

FileTransferUtilBenchmark imports FileTransferUtil, which #1917 removed when ReadableFile moved to an in-place FileStream.truncateTop().

This replaces it with FileStreamBenchmark, which benchmarks FileStream.truncateTop(long) on a 1MB file, the operation that took over from FileTransferUtil.transferBytes. Because truncateTop changes the file, the file is rewritten and reopened before each invocation (Level.Invocation), outside the measured time.

I assumed this might be more useful than just deleting it outright, but we don't seem to be running them in CI anyway so if we think we should just remove it, that works too.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 12:26
@jaydeluca
jaydeluca requested a review from a team as a code owner October 30, 2026 12:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@LikeTheSalad LikeTheSalad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jaydeluca

Tbh I forgot about this benchmark when adding the changes. I don't need it so I'm fine with removing it, and since it has been failing for so long without someone complaining, I don't think it would be missed. But I also don't have strong opinions on either option so, if there's some policy or pattern expected from modules to have some benchmarks or the like, it's fine for me as well if it stays.

@jaydeluca

Copy link
Copy Markdown
Member Author

@LikeTheSalad i'll remove it instead since it doesn't feel necessary, at least for now

@LikeTheSalad

Copy link
Copy Markdown
Contributor

@LikeTheSalad i'll remove it instead since it doesn't feel necessary, at least for now

Thanks again for taking a look into this.

@jaydeluca
jaydeluca enabled auto-merge October 30, 2026 13:29
@jaydeluca
jaydeluca disabled auto-merge October 30, 2026 13:29
@jaydeluca jaydeluca changed the title Update disk-buffering benchmark Remove disk-buffering benchmark Oct 30, 2026
@jaydeluca
jaydeluca enabled auto-merge November 17, 2026 10:25
@jaydeluca
jaydeluca added this pull request to the merge queue Nov 17, 2026
Merged via the queue into open-telemetry:main with commit 52db0b7 Nov 17, 2026
26 checks passed
@jaydeluca
jaydeluca deleted the update-benchmark branch November 17, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants