Repository navigation
gcp-resources: populate cloud.resource_id on Cloud Run and Cloud Functions - #3229
Merged
Merged
Conversation
…tions Populate the incubating cloud.resource_id resource attribute for Cloud Run services, Cloud Run jobs, and Cloud Functions when project ID, region, and service/job/function name are all non-empty.
dashpole
marked this pull request as ready for review
November 17, 2026 21:08
This was referenced Nov 17, 2026
Contributor
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
laurit
approved these changes
Nov 19, 2026
jaydeluca
approved these changes
Nov 19, 2026
Merged
via the queue into
open-telemetry:main
with commit Nov 19, 2026
8e76e67
40 of 43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Populate the incubating
cloud.resource_idresource attribute ingcp-resourcesfor Google Cloud Run services, Cloud Run jobs, and Cloud Functions://run.googleapis.com/projects/<cloud.account.id>/locations/<cloud.region>/services/<faas.name>//run.googleapis.com/projects/<cloud.account.id>/locations/<cloud.region>/jobs/<faas.name>//cloudfunctions.googleapis.com/projects/<cloud.account.id>/locations/<cloud.region>/functions/<faas.name>cloud.resource_idis emitted only whenprojectId,cloud.region, andfaas.nameare all non-null and non-empty, and is omitted on GCE, GKE, and App Engine. This matches the behavior recently added in open-telemetry/opentelemetry-go-contrib#10258.Existing Issue(s):
None in this repository (cross-language parity with open-telemetry/opentelemetry-go-contrib#10258).
Testing:
./gradlew :gcp-resources:spotlessCheck :gcp-resources:check --rerun-tasks --console=plain(65 tests acrossGCPResourceProviderTest,GcpMetadataConfigTest,GcpPlatformDetectorTest, andResourceComponentProviderTest: 0 failures, 0 errors, 0 skipped; Spotless, ErrorProne, and NullAway checks passed).GCPResourceProviderTestassertions for Cloud Run Service, Cloud Run Job, Cloud Functions, GCE, GKE, and App Engine, and added parameterized missing/empty component tests across all three serverless platforms.Documentation:
Updated
gcp-resources/README.mdto documentcloud.resource_iddetection for Cloud Run and Cloud Functions.Outstanding items:
None.