Repository navigation
Conversation
github-actions
Bot
requested review from
KarstenSchnitter,
srprash and
wangzlei
November 20, 2026 01:50
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the AWS and Cloud Foundry schema-version alignment.
No open issues 🎉
What changed in this PR
Aligns AWS and Cloud Foundry resource detectors with schema version 1.40.0 to address the reported merge conflicts that drop resource schema URLs. Detected attributes remain unchanged.
Changes:
- Updates AWS detector schema URLs from 1.25.0 to 1.40.0.
- Updates the Cloud Foundry detector schema URL from 1.24.0 to 1.40.0.
- Adjusts existing tests to expect the new schema version.
| File | Description |
|---|---|
cloudfoundry-resources/src/test/java/io/opentelemetry/contrib/cloudfoundry/resources/CloudFoundryResourceTest.java |
Updates the Cloud Foundry schema assertion. |
cloudfoundry-resources/src/main/java/io/opentelemetry/contrib/cloudfoundry/resources/CloudFoundryResource.java |
Sets the Cloud Foundry schema to 1.40.0. |
aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/LambdaResourceTest.java |
Updates Lambda schema assertions. |
aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/EksResourceTest.java |
Updates the EKS schema assertion. |
aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/EcsResourceTest.java |
Updates ECS metadata V3 and V4 schema assertions. |
aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/Ec2ResourceTest.java |
Updates EC2 IMDSv1 and IMDSv2 schema assertions. |
aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/BeanstalkResourceTest.java |
Updates the Beanstalk schema assertion. |
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/LambdaResource.java |
Sets the Lambda schema to 1.40.0. |
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EksResource.java |
Sets the EKS schema to 1.40.0. |
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EcsResource.java |
Sets the ECS schema to 1.40.0. |
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/Ec2Resource.java |
Sets the EC2 schema to 1.40.0. |
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/BeanstalkResource.java |
Sets the schema to 1.40.0 in both resource-return paths. |
Review effort: Balanced
trask
approved these changes
Nov 20, 2026
trask
left a comment
Member
There was a problem hiding this comment.
In case something works here, we added a test in open-telemetry/opentelemetry-java-instrumentation#20917 to know when the SDK bumps the version next time.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this error in test logs:
the attributes all exist in 1.40.0 so bumping them up to avoid losing the schema url