Skip to content

Replace NVD with Sonatype OSS Index#8186

Open
trask wants to merge 5 commits intoopen-telemetry:mainfrom
trask:align-generate-release-contributors
Open

Replace NVD with Sonatype OSS Index#8186
trask wants to merge 5 commits intoopen-telemetry:mainfrom
trask:align-generate-release-contributors

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Mar 13, 2026

Looks like a new CVE backing that better understands maven coordinates and so the suppressions we maintained previously should no longer be needed.

Ported from open-telemetry/opentelemetry-java-instrumentation#16445

Looks like a new CVE backing that better understands maven coordinates and so the suppressions we maintained previously should no longer be needed.

Ported from open-telemetry/opentelemetry-java-instrumentation#16445
@trask trask marked this pull request as ready for review March 13, 2026 18:17
@trask trask requested a review from a team as a code owner March 13, 2026 18:17
// Skip OWASP dependencyCheck task on test module
dependencyCheck {
skip = true
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no analog for this? Or is it no longer applicable?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is what you referred to with the suppressions no longer being needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're using a different plugin altogether now

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that. But we skipped OWASP on testing-internal because it had dependencies that triggered OWASP. And now we're not doing that. That means the new plugin either doesn't consider the testing dependencies problematic or somehow automatically excludes testing modules like this or something equivalent.

Just curious if you already know the answer.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, good point, I'll check this

trask and others added 3 commits March 17, 2026 13:57
Co-authored-by: Jack Berg <34418638+jack-berg@users.noreply.github.com>
@trask
Copy link
Copy Markdown
Member Author

trask commented Mar 20, 2026

Ran into an issue, let's wait for upstream fix: sonatype-nexus-community/scan-gradle-plugin#204

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (777213e) to head (c8d59d8).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8186      +/-   ##
============================================
- Coverage     90.30%   90.30%   -0.01%     
- Complexity     7651     7654       +3     
============================================
  Files           843      843              
  Lines         23061    23071      +10     
  Branches       2310     2311       +1     
============================================
+ Hits          20826    20835       +9     
- Misses         1516     1517       +1     
  Partials        719      719              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants