Open
Conversation
jack-berg
commented
Mar 19, 2026
| * @deprecated for removal after 1.55.0. Use {@link #isEnabled(Severity, Context)} or {@link | ||
| * #isEnabled(Severity)} instead. | ||
| */ | ||
| @Deprecated |
Member
Author
There was a problem hiding this comment.
Note, also removing this deprecated API
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (72.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8200 +/- ##
============================================
+ Coverage 90.29% 90.30% +0.01%
+ Complexity 7652 7651 -1
============================================
Files 843 843
Lines 23066 23073 +7
Branches 2310 2310
============================================
+ Hits 20827 20836 +9
+ Misses 1520 1519 -1
+ Partials 719 718 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkwatson
reviewed
Mar 25, 2026
| * the response is subject to change over the application, callers should call this before each | ||
| * call to {@link #logRecordBuilder()}. | ||
| */ | ||
| default boolean isEnabled(Severity severity, Context context) { |
Contributor
There was a problem hiding this comment.
why does this need the context as an additional parameter, but the tracer & instrument ones don't?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enabled concept API has been stabilized at the spec level across metrics, logs and traces: