test: add empty string and unicode edge cases to ValueTest#8219
Open
Tusharika725 wants to merge 3 commits intoopen-telemetry:mainfrom
Open
test: add empty string and unicode edge cases to ValueTest#8219Tusharika725 wants to merge 3 commits intoopen-telemetry:mainfrom
Tusharika725 wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8219 +/- ##
============================================
- Coverage 90.31% 90.31% -0.01%
+ Complexity 7653 7652 -1
============================================
Files 843 843
Lines 23066 23071 +5
Branches 2310 2311 +1
============================================
+ Hits 20832 20836 +4
Misses 1516 1516
- Partials 718 719 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
It would be extra-cool if you made this into a fuzz-test that would test a wider variety of possible inputs. I think there are examples of this in the codebase somewhere. (search for "fuzz") |
Author
|
"@jkwatson Thanks for the great suggestion! I've implemented a property-based fuzz test using JQF alongside the original deterministic tests. Let me know if you need any further adjustments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves an inline
TODOinValueTest.javato add more test cases.Added edge cases for the
valueByteAsString()method to ensure string encoding/decoding handles boundaries without data loss. Specifically added:All local tests pass.