Repository navigation
opentelemetry-resourcedetector-gcp: detect Cloud Run worker pools and instances, prefer K_CONFIGURATION over FUNCTION_TARGET, and clean up #5352 - #5363
Open
DylanRussell wants to merge 4 commits into
Conversation
…efer K_CONFIGURATION over FUNCTION_TARGET, and clean up open-telemetry#5352
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-19 21:36 UTC Review the latest changes. Status above doesn't look right?
|
opentelemetry-resourcedetector-gcp: detect Cloud Run worker pools, prefer K_CONFIGURATION over FUNCTION_TARGET, and clean up #5352
opentelemetry-resourcedetector-gcp: detect Cloud Run worker pools, prefer K_CONFIGURATION over FUNCTION_TARGET, and clean up #5352opentelemetry-resourcedetector-gcp: detect Cloud Run worker pools, instances, and Vertex AI Agent Engine; prefer K_CONFIGURATION over FUNCTION_TARGET
DylanRussell
force-pushed
the
fix-gcp-resourcedetector-cloud-run
branch
from
November 19, 2026 21:30
a0e1f1d to
7472d07
Compare
opentelemetry-resourcedetector-gcp: detect Cloud Run worker pools, instances, and Vertex AI Agent Engine; prefer K_CONFIGURATION over FUNCTION_TARGETopentelemetry-resourcedetector-gcp: detect Cloud Run worker pools and instances, prefer K_CONFIGURATION over FUNCTION_TARGET, and clean up #5352
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #5352 in
opentelemetry-resourcedetector-gcp(matching open-telemetry/opentelemetry-go-contrib#10350 and open-telemetry/opentelemetry-java-contrib#3233):K_CONFIGURATIONbeforeFUNCTION_TARGET: Cloud Run functions (gcloud run deploy --function) and Cloud Functions (2nd gen) both run as Cloud Run services and set bothK_CONFIGURATIONandFUNCTION_TARGET, whereas Cloud Functions (1st gen) only setsFUNCTION_TARGET.CLOUD_RUN_WORKER_POOLand optionalCLOUD_RUN_REVISION(faas.version) per the worker pools contract asgcp_cloud_runwithcloud.resource_id=//run.googleapis.com/projects/{project}/locations/{region}/workerPools/{name}.CLOUD_RUN_INSTANCE(docs) asgcp_cloud_runwithcloud.resource_id=//run.googleapis.com/projects/{project}/locations/{region}/instances/{name}.project_idparameter on_make_resource, update stale_faas.pyreference comment toopentelemetry-go-contrib, and clarify.changelog/5352.added.Tested live on GCP across Cloud Run services, jobs, worker pools, instances, and functions.
Type of change
cloud.platform=gcp_cloud_runinstead ofgcp_cloud_functions)Checklist:
tox -e precommittox -e typecheck