chore: use gemfile for dev dependencies#2095
Merged
kaylareopelle merged 15 commits intoMay 12, 2026
Merged
Conversation
thompson-tomo
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin and
xuan-cao-swi
as code owners
thompson-tomo
changed the title
thompson-tomo
commented
Apr 18, 2026
| @@ -27,13 +27,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency 'opentelemetry-api', '~> 1.0' | |||
|
|
|||
| spec.add_development_dependency 'benchmark-ipsa', '~> 0.2.0' | |||
| @@ -29,13 +29,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency 'opentelemetry-sdk', '~> 1.2' | |||
|
|
|||
| spec.add_development_dependency 'benchmark-ipsa', '~> 0.2.0' | |||
| @@ -28,12 +28,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency 'opentelemetry-api', '~> 1.0' | |||
|
|
|||
| spec.add_development_dependency 'kramdown', '~> 2.3' | |||
thompson-tomo
force-pushed
the
gemfile_switch
branch
from
3f1ff24 to
3807483
Compare
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Apologies for all the merge conflicts from the other PRs. Here's a few suggestions to tackle the known problems related to the benchmark PRs.
| @@ -28,13 +28,6 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_development_dependency 'benchmark-ipsa', '~> 0.2.0' | |||
Contributor
There was a problem hiding this comment.
Suggested change
| spec.add_development_dependency 'benchmark-ipsa', '~> 0.2.0' |
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Contributor
Author
|
No worries @kaylareopelle thanks for the assist. The conflicts have been resolved & should now be ready for merge/review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2021
This switches dev dependencies to gemfile when they are commonly used. This allows renovate to manage them and allows us to progress with removing rubocop suppression.