Repository navigation
fix(plugin): select a SQLite-capable Node runtime on Linux - #2499
mldangelo-oai wants to merge 2 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
Security findingsBlocking findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 648c0512c8
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
|
@codex security review |
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for the focused fix. No blocking findings in this merge-safety review. The current fallback addresses the earlier PATH-probing concern while keeping explicit runtime selection authoritative. One nonblocking suggestion below would make the probe independent of diagnostic output.
Verified nine packaged-launcher tests, the fresh/resumed worker runtime boundary test, nine portable source tests, and the exact-head plugin build. Native Windows/macOS execution and a successful Linux system-Node fallback were not independently exercised; this host has no qualifying system SQLite runtime.
The extracted-package helper smoke also passed all four cases. An adjacent SDK compressed-read test timed out at 30 seconds; its fixture calls the unchanged SDK/Python path without this launcher, and that timeout remains unqualified.
| } | ||
| ' "$launcher_dir/../mcp" </dev/null 2>&1) | ||
| ' "$launcher_dir/../mcp" </dev/null 2>&1) || return 1 | ||
| [ "$_native_probe_output" = linux-without-sqlite ] || return 0 |
There was a problem hiding this comment.
Nonblocking: consider distinguishing missing SQLite with a probe exit status. This value combines stdout and stderr, so enabling the standard NODE_DEBUG=module setting (or a runtime emitting a startup warning) makes the output differ from exactly linux-without-sqlite. The incompatible first runtime is then treated as usable and the system fallback is skipped. A distinct status would avoid parsing diagnostic text while preserving the current restriction to system candidates.
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
On Linux, the plugin launcher accepted the first automatic Node candidate even when it lacked the built-in SQLite module. With Node 20 ahead of a supported Node release, the workbench database helper failed at startup with
No such built-in module: node:sqlite.Changes
Check SQLite support in the existing runtime probe before starting a helper. If the selected Linux Node lacks SQLite, look for a compatible system installation in the standard Linux binary directories. Added a Linux test through the packaged launcher and checked the automatic runtime candidate in fresh and resumed Deep Scan worker processes.
Testing
Risk and rollout
A Linux Node missing SQLite can use a system Node in
/usr/local/bin,/usr/bin, or/bin. The system candidate must resolve to one of those directories. ExplicitCODEX_MCP_NODE_PATHoverrides still launch directly. When a compatible system installation is unavailable, the originally selected runtime handles the command.Public disclosure review