Skip to content

fix(package): preserve LF in the POSIX MCP launcher on Windows - #2500

Merged
mldangelo-oai merged 1 commit into
mainfrom
dev/codex/windows-posix-launcher-eol
Nov 9, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
dev/codex/windows-posix-launcher-eol

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

A Windows checkout with core.autocrlf=true could pack the extensionless POSIX MCP launcher with a carriage return in its shebang. A Linux kernel then returned ENOENT when executing the installed file, preventing MCP and its documented helpers from starting.

Changes

  • Mark the extensionless launcher as LF text in Git. Touch the tracked launcher so an existing Windows checkout receives the corrected bytes on its next fast-forward pull.
  • Check the launcher's actual tarball bytes for carriage returns and cover both shebang and body regressions.

Testing

  • An existing Windows checkout with 102 CRLF line endings received an LF-only launcher after a real git pull --ff-only. A fresh checkout produced the same bytes.
  • Used the Linux kernel in WSL2 to execute both mode-0755 tar entries directly. The original returned ENOENT. The fixed launcher passed the configured server path and --stdio to a harmless test executable and exited successfully. Verified byte-for-byte identity of the Windows batch launcher in both packages.
  • Passed 31 tarball checks, 11 Windows MCP launcher checks, eight portable source checks and validation of all 952 entries in the corrected npm archive. SDK build, types, formatting and Python lint checks also passed.

Risk and rollout

The EOL rule names the single POSIX launcher. The package check rejects an archive containing a carriage return in that executable before release.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Nov 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T20:19:17.787400Z 54a9a30 PR opened
🔒 Security Review ✅ Completed 2026-11-09T20:19:54.596597Z 54a9a30 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai mldangelo-oai added the platform:windows Windows, PowerShell, Windows paths, or Windows ACLs label Nov 9, 2026 — with ChatGPT Codex Connector

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. No blocking findings in this merge-safety review. The scoped LF attribute, launcher rewrite, and packaged-byte checks address both existing checkouts and published archives.

Verified all 31 tarball tests, nine portable source tests, TypeScript, Ruff, and formatting. An autocrlf checkout smoke changed the launcher from 102 CRLF endings to LF-only and passed direct Linux execution with the expected arguments. Native Windows execution and the full SDK suite were not independently run.

@mldangelo-oai
mldangelo-oai merged commit ea8c166 into main Nov 9, 2026
138 of 140 checks passed
@mldangelo-oai
mldangelo-oai deleted the dev/codex/windows-posix-launcher-eol branch November 9, 2026 21:25
@github-actions github-actions Bot mentioned this pull request Nov 9, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working platform:windows Windows, PowerShell, Windows paths, or Windows ACLs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants