Skip to content

feat(scanner-imports): add ArmorCode findings support - #2606

Closed
dy-armorcode wants to merge 1 commit into
openai:mainfrom
armor-code:feat/armorcode-sast
Closed

feat(scanner-imports): add ArmorCode findings support#2606
dy-armorcode wants to merge 1 commit into
openai:mainfrom
armor-code:feat/armorcode-sast

Conversation

@dy-armorcode

@dy-armorcode dy-armorcode commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

This PR adds support to process SAST type findings from ArmorCode

@github-actions github-actions Bot added the enhancement New feature or request label Nov 11, 2026
mldangelo-oai
mldangelo-oai approved these changes Nov 11, 2026
View reviewed changes

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing the ArmorCode SAST importer! I ran a two-finding sample through the local workbench and checked the saved locations, rules, and scanner verdicts. Re-importing the same report preserved both finding IDs and created no duplicates. I appreciate the care you took to keep the original scanner evidence available for triage.

@mldangelo-oai mldangelo-oai mentioned this pull request Nov 11, 2026
Merged
3 tasks done
@mldangelo-oai ChatGPT Codex Connector

mldangelo-oai commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thanks again for the contribution. I resolved the conflict with upstream main, verified the local workbench import, and opened #2608 to carry your original commit through CI. The updated branch also includes the repository-matching fix requested in review. To continue under this PR number, you can fast-forward feat/armorcode-sast to 815e74af.

mldangelo-oai added a commit that referenced this pull request Nov 11, 2026
@mldangelo-oai @dy-armorcode
feat(scanner-imports): add ArmorCode findings support (#2608)
5aa4d39 
Carry forward the reader contributed in #2606. Include it in the SDK package and validate repository claims when preparing an import.

Co-authored-by: dy-armorcode <109572335+dy-armorcode@users.noreply.github.com>
@mldangelo-oai ChatGPT Codex Connector

mldangelo-oai commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks for contributing the importer! It landed on main through #2608 after review and CI. The merge commit credits the original contribution. Closing this PR now that the change is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mldangelo-oai mldangelo-oai mldangelo-oai approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dy-armorcode @mldangelo-oai