Skip to content

fix(cli): clarify blocked patch results - #2609

Merged
utsav-oai merged 4 commits into
mainfrom
fix/clarify-blocked-patch-results
Nov 11, 2026
Merged

utsav-oai merged 4 commits into
mainfrom
fix/clarify-blocked-patch-results

Conversation

@utsav-oai

Copy link
Copy Markdown
Contributor

Summary

When patch preparation is blocked, users need to know whether any files changed and what has to happen next. This is especially important when a required change belongs outside the writable checkout.

Changes

The shared CLI prompt asks blocked results to explain what stopped the fix and what needs to happen next. When a fix depends on work outside the checkout, the explanation describes what the external component does, why it matters to the fix, and where the change belongs when known. It assumes the reader only knows the current repository.

Testing

  • SDK type checks, formatting, and all 77 hosted remediation and CLI patch result tests passed.
  • The earlier run that also included the broader CLI patch suite had 174 passes and 10 failures. The same 10 failures reproduced on unmodified main.
  • The full SDK suite stopped after fixture ownership checks failed in the test environment.

Risk and rollout

This changes the instructions used to write blocked-result summaries. Hosted runs pick up the prompt with a CLI release. Model output has yet to be evaluated in a live run.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Nov 11, 2026
@utsav-oai
utsav-oai marked this pull request as ready for review November 11, 2026 18:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-11T18:46:48.334541Z 41e9299 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mluck-openai

Copy link
Copy Markdown
Collaborator

lgtm!

one thing to clarify - does this change anything about the schema between CLI and CSC? I don't recall if reason is a strict or an unstructured field

@utsav-oai

utsav-oai commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

lgtm!

one thing to clarify - does this change anything about the schema between CLI and CSC? I don't recall if reason is a strict or an unstructured field

this change doesn't have any schema changes, only prompt changes, so we should be fine. the reason field already exists.

@utsav-oai
utsav-oai merged commit ca7a25e into main Nov 11, 2026
63 checks passed
@utsav-oai
utsav-oai deleted the fix/clarify-blocked-patch-results branch November 11, 2026 19:05
@github-actions github-actions Bot mentioned this pull request Nov 11, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants