Fix remote TUI cwd decoding across OSes#21476
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94944bee41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
fcoury-oai
left a comment
There was a problem hiding this comment.
I tested this from Windows against a Linux remote app-server. It gets further than before, but I think the PR still doesn't fully fix the issue yet.
The TUI starts, but then skills/list fails with:
AbsolutePathBuf deserialized without a base path
And submitting a prompt fails at turn/start.
So this seems to fix part of the lifecycle path, but not the full cross-OS remote TUI flow described by the title/body.
I think we either need to expand the fix to the other remote app-server responses that carry server paths, or narrow the PR scope/title.
Fixes #21357.
Why
Native Windows TUI sessions connected to a remote app-server running on another OS can fail during thread lifecycle bootstrap because v2 thread lifecycle responses carry server filesystem paths in
AbsolutePathBuffields. A Linux app-server can return paths such as/home/..., which are not local absolute paths on Windows, so typed deserialization fails before the TUI can finishthread/start.What changed
thread/start,thread/resume, andthread/forkresponses through a shared lifecycle helper that captures the raw server cwd and deserializes with a localAbsolutePathBufGuard.turn/startrequests so the TUI does not send locally decoded placeholder paths back to the app-server.Verification
cargo test -p codex-tui app_server_sessionjust fix -p codex-tui