Revert blocking state DB initialization#21483
Open
pakrym-oai wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #20689 made app-server startup require successful SQLite state DB initialization. That turns a local state-store failure into a process startup failure. Before that change, Codex logged the initialization failure and continued with DB-backed features disabled or degraded.
This PR restores the previous nonblocking behavior without creating a temporary or fake runtime DB.
What Changed
Option<StateDbHandle>through app-server, in-process app-server, coreThreadManager, MCP server, and localThreadStore.Verification
cargo test -p codex-app-server --libcargo test -p codex-core --libcargo test -p codex-thread-storecodex-coreagent/session/multi-agent testscargo check -p codex-core -p codex-app-server -p codex-mcp-server -p codex-thread-manager-sample -p codex-thread-store -p codex-app-server-clientjust fix -p codex-core -p codex-core-api -p codex-app-server -p codex-app-server-client -p codex-mcp-server -p codex-thread-manager-sample -p codex-thread-store