Open
Conversation
918933d to
9183997
Compare
Contributor
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perCwdExtraUserRoots/SkillsListExtraRootsForCwdfrom theskills/listapp-server API.codex-core-skillsextra-root plumbing so skill scans are keyed by the normal cwd/user/plugin roots only.Validation
just write-app-server-schemajust fmtcargo test -p codex-app-server-protocolcargo test -p codex-core-skillsjust fix -p codex-app-server-protocoljust fix -p codex-core-skillsjust fix -p codex-app-serverjust fix -p codex-tuiNotes
cargo test -p codex-app-server --test all skills_listran the edited skills-list cases, but the full filtered run ended on existingskills_changed_notification_is_emitted_after_skill_changetimeout after a websocket401.cargo test -p codex-tui --libcompiled the changed TUI callers, then failed two unrelated status permission tests because local/etc/codex/requirements.tomlforbidsDangerFullAccess.