Skip to content

Remove skills list extra roots#21485

Open
xli-oai wants to merge 3 commits intomainfrom
xli-codex/remove-skills-extra-roots
Open

Remove skills list extra roots#21485
xli-oai wants to merge 3 commits intomainfrom
xli-codex/remove-skills-extra-roots

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented May 7, 2026

Summary

  • Remove perCwdExtraUserRoots / SkillsListExtraRootsForCwd from the skills/list app-server API.
  • Drop Rust app-server and codex-core-skills extra-root plumbing so skill scans are keyed by the normal cwd/user/plugin roots only.
  • Regenerate app-server schemas and update docs/tests that only existed for the removed extra-roots behavior.

Validation

  • just write-app-server-schema
  • just fmt
  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-core-skills
  • just fix -p codex-app-server-protocol
  • just fix -p codex-core-skills
  • just fix -p codex-app-server
  • just fix -p codex-tui

Notes

  • cargo test -p codex-app-server --test all skills_list ran the edited skills-list cases, but the full filtered run ended on existing skills_changed_notification_is_emitted_after_skill_change timeout after a websocket 401.
  • cargo test -p codex-tui --lib compiled the changed TUI callers, then failed two unrelated status permission tests because local /etc/codex/requirements.toml forbids DangerFullAccess.
  • Source-truth check found the OpenAI monorepo still has generated/app-server-kit mirror references to the removed field; those should be cleaned up when generated app-server types are synced or in a companion OpenAI cleanup.

@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label May 7, 2026 — with ChatGPT Codex Connector
@xli-oai xli-oai force-pushed the xli-codex/remove-skills-extra-roots branch from 918933d to 9183997 Compare May 7, 2026 05:41
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented May 7, 2026

@codex review

@xli-oai xli-oai marked this pull request as ready for review May 7, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant