device-key: clean up unused crate#21487
Open
euroelessar wants to merge 6 commits intomainfrom
Open
Conversation
euroelessar
added a commit
that referenced
this pull request
May 7, 2026
euroelessar
added a commit
that referenced
this pull request
May 7, 2026
euroelessar
added a commit
that referenced
this pull request
May 7, 2026
f922ffa to
7bb65bf
Compare
euroelessar
added a commit
that referenced
this pull request
May 7, 2026
03aba00 to
c1f1cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The device-key implementation is no longer used, but it still leaves behind a standalone crate plus app-server RPC, schema, state, and test surface area. Keeping that dead surface in the tree increases maintenance cost and makes the active remote-control protocol harder to read.
What changed
codex-device-keycrate and workspace dependencydevice/key/*app-server RPCs, request handling, tests, and generated schema artifactsremote_controlprotocol moduleapp-server/README.mdto drop the removed APIsValidation
git diff --checkcargo test -p codex-app-server-protocolandcargo test -p codex-app-server, but both were blocked in this environment by the pinnedcrosstermgit dependency fetch returning HTTP403justversion is too old for this repo'sjustfile; the checked-in generated artifacts were updated to match the removed source surface